Skip to content

experiment: add confirm dialog base styles and visual tests - #9474

Merged
web-padawan merged 11 commits into
mainfrom
experiment/base-confirm-dialog
Jun 27, 2025
Merged

web-padawan merged 11 commits into
mainfrom
experiment/base-confirm-dialog

Conversation

@jouni

@jouni jouni commented Jun 17, 2025 •

Copy link
Copy Markdown
Member

Depends on #9438

Screenshot 2025-06-17 at 9 56 04

Supported custom properties

All the properties that Dialog exposes: #9438

Property Fallback value
--vaadin-confirm-dialog-min-width 15em
--vaadin-confirm-dialog-max-width 25em

@jouni jouni changed the title experiment: Confirm Dialog base styles experiment: add confirm dialog base styles and visual tests Jun 18, 2025
@web-padawan
web-padawan force-pushed the experiment/base-confirm-dialog branch from bc59a7b to 508087a Compare June 24, 2025 06:39

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual tests with ported Lumo fail due to heading styles being reset, @vursen FYI.

Screenshot 2025-06-24 at 10 06 59

@web-padawan
web-padawan force-pushed the experiment/base-confirm-dialog branch from 209b15c to 64e6838 Compare June 27, 2025 11:22
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 353c193 into main Jun 27, 2025
@web-padawan
web-padawan deleted the experiment/base-confirm-dialog branch June 27, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants