Repository navigation
experiment: add confirm dialog base styles and visual tests - #9474
Merged
Merged
Conversation
jouni
commented
Jun 17, 2025
web-padawan
force-pushed
the
experiment/base-confirm-dialog
branch
from
June 24, 2025 06:39
bc59a7b to
508087a
Compare
web-padawan
reviewed
Jun 24, 2025
web-padawan
left a comment
Member
There was a problem hiding this comment.
Visual tests with ported Lumo fail due to heading styles being reset, @vursen FYI.
web-padawan
reviewed
Jun 24, 2025
- initialize core and base styles - Update confirm-dialog.html - fix: hide reject button part when not used. This avoids an unnecessary layout gap. - base styles
web-padawan
force-pushed
the
experiment/base-confirm-dialog
branch
from
June 27, 2025 11:22
209b15c to
64e6838
Compare
|
web-padawan
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Depends on #9438
Supported custom properties
All the properties that Dialog exposes: #9438
--vaadin-confirm-dialog-min-width--vaadin-confirm-dialog-max-width