Skip to content

chore: improve menu-bar dev page - #9549

Merged
DiegoCardoso merged 4 commits into
mainfrom
chore/menu-bar/dev-page
Jun 26, 2025
Merged

DiegoCardoso merged 4 commits into
mainfrom
chore/menu-bar/dev-page

Conversation

@DiegoCardoso

Copy link
Copy Markdown
Contributor

Description

Add a way to select themes and disable/enable the menu-bar, as well as move it inside of a split-layout element to make it easier to resize it.

Comment thread dev/menu-bar.html

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev page could include some checkable menu items to test the selection checkmark / indicator.

I also noticed that using RTL would impact styles quite a bit, though we haven't covered that in other dev pages. @jouni how have you been testing that so far? Should we include a toggle for that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a toggle for that would indeed be very helpful. Now I just manually add <html dir=rtl> once I’m almost finished with the styles, and then fix any issues I notice at that point.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some checkable options and a new select for direction mode.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Chrome inspector has some easy toggle for that already. I think would suffice as well, if it’s easily accessible.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also create a bookmarklet to add the attribute.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can still wish, I’d want a radio group instead of a select when there are only 2–3 options. One less click.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to radio groups instead of select.

@sonarqubecloud

Copy link
Copy Markdown

@DiegoCardoso
DiegoCardoso merged commit d87f6fa into main Jun 26, 2025
@DiegoCardoso
DiegoCardoso deleted the chore/menu-bar/dev-page branch June 26, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants