Repository navigation
test: extract and extend select focus related tests - #9575
Merged
Merged
Conversation
|
web-padawan
commented
Jun 28, 2025
| }); | ||
|
|
||
| it('should restore focused state on closing the overlay if phone', async () => { | ||
| select._phone = true; |
Member
Author
There was a problem hiding this comment.
The closing logic specific to _phone has been removed in #3120 as part of an a11y fix, so there is no need for separate tests covering this mode anymore.
web-padawan
commented
Jun 28, 2025
| expect(focusedSpy.called).to.be.true; | ||
| }); | ||
|
|
||
| it('should focus the button before moving the focus to next selectable element', async () => { |
Member
Author
There was a problem hiding this comment.
Replaced this with better tests using sendKeys that actually ensure that focus is eventually moved to the first / last global focusable on overlay item Tab and Shift + Tab respectively.
vursen
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Extracted and improved select focus tests in preparation for the upcoming native popover refactoring.
Type of change