Repository navigation
experiment: add popover base styles and visual tests - #9638
Merged
Merged
Conversation
Contributor
web-padawan
force-pushed
the
experiment/base-popover
branch
from
July 4, 2025 11:21
799daf9 to
fe0e654
Compare
Member
Author
|
@DiegoCardoso Thanks, added missing styles and updated arrow to adapt to the outline. Also added visual tests. |
DiegoCardoso
approved these changes
Jul 4, 2025
Member
|
I have some improvements in the works, I'll continue with them on Monday. |
|
Member
jouni
approved these changes
Jul 7, 2025
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Depends on #9631
Type of change