Skip to content

experiment: add context-menu base styles and visual tests - #9642

Merged
web-padawan merged 14 commits into
mainfrom
base-context-menu
Jul 8, 2025
Merged

web-padawan merged 14 commits into
mainfrom
base-context-menu

Conversation

@anezthes

@anezthes anezthes commented Jul 4, 2025 •

Copy link
Copy Markdown
Contributor

New ContextMenu base style

localhost_8000_dev_context-menu html

Supported custom properties

No new properties added.

Concerns

The menu-item-checked selector appears in both context-menu-item-base-styles and menu-bar-item-base-styles. Consider moving it to item-base-styles to avoid duplication?

@jouni

jouni commented Jul 7, 2025

Copy link
Copy Markdown
Member

Styles LGTM. @web-padawan, can you coordinate/handle the visual tests?

@web-padawan

Copy link
Copy Markdown
Member

Merged the CSS layer removal PR, I'll rebase this one and add visual tests.

@web-padawan web-padawan changed the title refactor!: Base ContextMenu styles experiment: add context-menu base styles and visual tests Jul 8, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2025

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit c29bfc3 into main Jul 8, 2025
@web-padawan
web-padawan deleted the base-context-menu branch July 8, 2025 09:16
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants