Repository navigation
refactor: simplify menu-bar observers to reduce update count - #9649
Merged
Merged
Conversation
vursen
approved these changes
Jul 7, 2025
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.0-alpha2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Follow-up to #9618
Previously, we were setting
_containerafter a microtask to delay running observers. This is no longer needed.updated(), which runs afterready(), instead of individual observers that run beforeready(). This way it runs after both_containerand_overfloware set, which eliminates the need to define them instatic get properties(). As a result we get one update less during an initial render of the component._hasOverflowto not be a reactive property either, otherwise setting it on resize (e.g. when inside of a split layout on the dev page) triggers update cycle for the component unnecessarily, whereas in fact we only need to set or remove the attribute.ready()block.Type of change