Skip to content

refactor: update avatar-group to use has-overflow host attribute - #9657

Merged
web-padawan merged 1 commit into
mainfrom
refactor/avatar-group-has-overflow
Jul 8, 2025
Merged

web-padawan merged 1 commit into
mainfrom
refactor/avatar-group-has-overflow

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Replaced .has-overflow class on the container added in #9298 with the state attribute.

IMO it makes more sense this way, although I'm not sure whether we should document it as public styling API.

Type of change

  • Refactor

@web-padawan
web-padawan requested review from jouni and vursen July 8, 2025 07:00
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2025

Copy link
Copy Markdown

@jouni jouni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wanted to avoid the discussion of new public API earlier, that’s why I used an internal class. I was perhaps thinking that the same might be possible in the future with something like vaadin-avatar-group:has([slot='overflow']).

@web-padawan
web-padawan removed the request for review from vursen July 8, 2025 07:23
@web-padawan
web-padawan merged commit 88c51dd into main Jul 8, 2025
@web-padawan
web-padawan deleted the refactor/avatar-group-has-overflow branch July 8, 2025 07:23
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants