Skip to content

refactor: remove no longer used setNestedOverlay logic and tests - #9813

Merged
web-padawan merged 1 commit into
mainfrom
refactor/remove-nested-overlay-logic
Jul 28, 2025
Merged

web-padawan merged 1 commit into
mainfrom
refactor/remove-nested-overlay-logic

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

This logic is no longer used anywhere after upgrading vaadin-popover to use native popover in #9785.

I tested the modeless dialog & popover combinations and it seems we don't need to call bringToFront() for nested overlays, especially because popover always closes on outside click since #8409. All other overlay components e.g. vaadin-date-picker use modal overlays so they also close on outside click, and were not affected by #8521.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from sissbruecker July 28, 2025 11:08
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 460cf83 into main Jul 28, 2025
@web-padawan
web-padawan deleted the refactor/remove-nested-overlay-logic branch July 28, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants