Repository navigation
refactor: remove no longer used setNestedOverlay logic and tests - #9813
Merged
Merged
Conversation
|
sissbruecker
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This logic is no longer used anywhere after upgrading
vaadin-popoverto use native popover in #9785.I tested the modeless dialog & popover combinations and it seems we don't need to call
bringToFront()for nested overlays, especially because popover always closes on outside click since #8409. All other overlay components e.g.vaadin-date-pickeruse modal overlays so they also close on outside click, and were not affected by #8521.Type of change