Skip to content

experiment: add charts base styles and visual tests - #9830

Merged
web-padawan merged 13 commits into
mainfrom
experiment/base-charts
Jul 30, 2025
Merged

web-padawan merged 13 commits into
mainfrom
experiment/base-charts

Conversation

@jouni

@jouni jouni commented Jul 30, 2025

Copy link
Copy Markdown
Member
Screenshot 2025-07-30 at 12 27 20 Screenshot 2025-07-30 at 12 27 28

Supported custom properties

--vaadin-charts-background
--vaadin-charts-title-label
--vaadin-charts-axis-title
--vaadin-charts-axis-label
--vaadin-charts-data-label
--vaadin-charts-secondary-label
--vaadin-charts-axis-line
--vaadin-charts-grid-line
--vaadin-charts-disabled-label
--vaadin-charts-contrast
--vaadin-charts-tooltip-background
--vaadin-charts-tooltip-border-color
--vaadin-charts-button-label
--vaadin-charts-button-background
--vaadin-charts-button-hover-background
--vaadin-charts-button-active-label
--vaadin-charts-button-active-background
--vaadin-charts-button-border-radius
--vaadin-charts-xaxis-line-width
--vaadin-charts-tooltip-background-opacity
--vaadin-charts-color-0
--vaadin-charts-color-1
--vaadin-charts-color-2
--vaadin-charts-color-3
--vaadin-charts-color-4
--vaadin-charts-color-5
--vaadin-charts-color-6
--vaadin-charts-color-7
--vaadin-charts-color-8
--vaadin-charts-color-9
--vaadin-charts-color-positive
--vaadin-charts-color-negative
--vaadin-charts-org-line
--vaadin-charts-org-line-width
--vaadin-charts-range-input-background
--vaadin-charts-range-input-background-hover

@web-padawan

Copy link
Copy Markdown
Member

Created a PR to allow empty lines between custom CSS properties blocks: #9832

@web-padawan
web-padawan force-pushed the experiment/base-charts branch from 18d788d to 3512a8d Compare July 30, 2025 10:42
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan

Copy link
Copy Markdown
Member

Note: this test will need to be changed when switching to use base styles by default:

expect(getComputedStyle(rects[1]).fill).to.equal('rgb(22, 118, 243)');

@web-padawan
web-padawan merged commit 1031a9d into main Jul 30, 2025
@web-padawan
web-padawan deleted the experiment/base-charts branch July 30, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants