Skip to content

fix: add CSS to make Lumo dialog content overflow work - #9993

Merged
web-padawan merged 1 commit into
mainfrom
fix/dialog-overflow-lumo
Aug 14, 2025
Merged

web-padawan merged 1 commit into
mainfrom
fix/dialog-overflow-lumo

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #9992

Type of change

  • Bugfix

min-width: 12em; /* matches the default <vaadin-text-field> width */
padding: var(--lumo-space-l);
flex: 1;
min-height: 0;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix.

display: none !important;
}

:host(:is([has-title], [has-header], [has-footer])) [part='content'] {

@web-padawan web-padawan Aug 13, 2025 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we still need this at all after the change in #9903, maybe could be removed altogether.
Seems like this override was supposed to cover height: 100% in the resizable overlay styles.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: removed it from this PR.

@web-padawan
web-padawan force-pushed the fix/dialog-overflow-lumo branch from 05457c0 to 4eed10c Compare August 13, 2025 15:38
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 1c34c3b into main Aug 14, 2025
@web-padawan
web-padawan deleted the fix/dialog-overflow-lumo branch August 14, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dialog] Content overflows overlay

2 participants