Skip to content

correct description of skipMiddlewareUrlNormalize in advanced middleware flags - #60841

Merged
samcx merged 3 commits into
vercel:canaryfrom
Evavic44:patch-2
Jan 19, 2024
Merged

samcx merged 3 commits into
vercel:canaryfrom
Evavic44:patch-2

Conversation

@Evavic44

Copy link
Copy Markdown
Contributor

I think there's some form of typographical error in the skipMiddlewareUrlNormalize line under the advanced middleware flags section of the docs.

This is the line from the docs Source link:

skipMiddlewareUrlNormalize allows disabling the URL normalizing Next.js does to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.

Corrected to:

skipMiddlewareUrlNormalize allows disabling URL normalizing in Next.js to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.

…nced middleware flags

I think there's some form of typographical error in the `skipMiddlewareUrlNormalize` line under the advanced middleware flags section of the docs.

This is the line from the docs [Source link](https://nextjs.org/docs/app/building-your-application/routing/middleware#advanced-middleware-flags):

```
skipMiddlewareUrlNormalize allows disabling the URL normalizing Next.js does to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.
```

Corrected to:

```
skipMiddlewareUrlNormalize allows disabling URL normalizing in Next.js to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.
```
@Evavic44
Evavic44 requested review from a team as code owners January 18, 2024 19:24
@Evavic44
Evavic44 requested review from leerob and manovotny and removed request for a team January 18, 2024 19:24
Comment thread docs/02-app/01-building-your-application/01-routing/13-middleware.mdx Outdated
…are.mdx

Co-authored-by: Sam Ko <sam@vercel.com>
@samcx
samcx self-requested a review January 19, 2024 06:00
@ijjk

ijjk commented Jan 19, 2024

Copy link
Copy Markdown
Member

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk

ijjk commented Jan 19, 2024

Copy link
Copy Markdown
Member

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk

ijjk commented Jan 19, 2024

Copy link
Copy Markdown
Member

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx
samcx enabled auto-merge (squash) January 19, 2024 06:04
@samcx
samcx merged commit 2de7f95 into vercel:canary Jan 19, 2024
@Evavic44
Evavic44 deleted the patch-2 branch January 19, 2024 06:10
@github-actions github-actions Bot added the locked label Feb 6, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants