fix: Ensure preload runs only on client - #4213
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
@copilot where are you? |
Co-authored-by: shuding <3676859+shuding@users.noreply.github.com>
Co-authored-by: shuding <3676859+shuding@users.noreply.github.com>
shuding
marked this pull request as ready for review
January 30, 2026 17:41
shuding
changed the title
shuding
approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds server-side safety to the preload() function by making it a no-op when executed on the server. The implementation uses the existing IS_SERVER flag to detect server environments and returns undefined without executing the fetcher or modifying cache state.
Changes:
- Added early return in
preload()function whenIS_SERVERis true - Added test coverage to verify server-side no-op behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/_internal/utils/preload.ts | Adds server-side check to return undefined early, preventing fetcher execution and cache modifications on the server |
| test/use-swr-server.test.tsx | Adds test suite to verify that preload returns undefined and doesn't call the fetcher in server environments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.