Repository navigation
fix(bundled-dev): emit assets referenced by inline workers during load - #23103
Conversation
|
Instead of adding tests to |
|
cc @h-a-n-a |
|
I don't feel like there's anything that blocks us from adding this to the
What're the issues you were referring to here? |
|
the worker playground is now disabled, so I assumed there are many tests failing Lines 29 to 32 in 02cffa9 |
I see. I haven't checked these yet. Maybe we should try to enable the test and see if anything fails and use |
|
I tried to enable worker bundled-dev test cases. Unlike other enabled test cases in Vite playground. These cases were not triaged. But I feel like we can remove it from the exclude list first and gradually enable them. #23289 cc @sapphi-red |
|
I've verified this locally, and it seems I can't enable any of the test cases skipped in #23289. |
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [vite](https://vite.dev) ([source](https://github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`8.3.7` → `8.3.8`](https://renovatebot.com/diffs/npm/vite/8.3.7/8.3.8) |  |  | --- ### Release Notes <details> <summary>vitejs/vite (vite)</summary> ### [`v8.3.8`](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-838-2026-11-11-small) [Compare Source](vitejs/vite@v8.3.7...v8.3.8) ##### Bug Fixes - **build:** keep `magicString` and `ast` in transform hook meta ([#​24012](vitejs/vite#24012)) ([a3b28e8](vitejs/vite@a3b28e8)) - **bundled-dev:** emit assets referenced by inline workers during load ([#​23103](vitejs/vite#23103)) ([5e50bae](vitejs/vite@5e50bae)) - **config:** skip native loader compat checks for type-only imports ([#​24021](vitejs/vite#24021)) ([e554294](vitejs/vite@e554294)) - **css:** reject CSS entrypoints when `build.cssCodeSplit: false` ([#​23112](vitejs/vite#23112)) ([e4ad62b](vitejs/vite@e4ad62b)) - **deps:** update all non-major dependencies ([#​24027](vitejs/vite#24027)) ([a13aa04](vitejs/vite@a13aa04)) - hide console window when running `yarn config get` on Windows ([#​24013](vitejs/vite#24013)) ([3f6c4cd](vitejs/vite@3f6c4cd)) ##### Performance Improvements - **css:** import sass once instead of per file ([#​24041](vitejs/vite#24041)) ([db8b119](vitejs/vite@db8b119)) - defer `net use` until a UNC path is resolved on Windows ([#​24014](vitejs/vite#24014)) ([b643046](vitejs/vite@b643046)) ##### Miscellaneous Chores - **deps:** update dependency [@​types/node](https://github.com/types/node) to v26 ([#​24029](vitejs/vite#24029)) ([dd780cd](vitejs/vite@dd780cd)) - enable vitest plugin in Oxlint ([#​24052](vitejs/vite#24052)) ([ce979e4](vitejs/vite@ce979e4)) - enable vitest style rules in Oxlint ([#​24053](vitejs/vite#24053)) ([b8c8270](vitejs/vite@b8c8270)) - revert "fix(build): keep `magicString` and `ast` in transform hook meta ([#​24012](vitejs/vite#24012))" ([#​24065](vitejs/vite#24065)) ([afc44f0](vitejs/vite@afc44f0)) ##### Code Refactoring - **optimizer:** use non-capturing group for external types regex ([#​24048](vitejs/vite#24048)) ([ef23433](vitejs/vite@ef23433)) ##### Tests - avoid joining logs for assertion ([#​24057](vitejs/vite#24057)) ([fbb0a4e](vitejs/vite@fbb0a4e)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMzkuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjIzOS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
The inline branch of
vite:worker(?worker&inline,?sharedworker&inline) embeds the worker entry as a blob URL, but assets the worker references are still emitted as separate files. Those files normally reach the output throughgenerateBundle, which an HMR patch skips. When the worker is re-bundled for a patch, the referenced asset gets a new content-hash filename that was never emitted, so requests for it fall through to the SPA fallback and returntext/html.Emit the cached worker assets during
loadin the inline branch as well, matching the non-inline branch from #23068.