Skip to content

fix(valid-title): handle missing argument in valid-title rule - #942

Merged
veritem merged 1 commit into
vitest-dev:mainfrom
ysknsid25:fix/handle-missing-argument
Aug 10, 2026
Merged

veritem merged 1 commit into
vitest-dev:mainfrom
ysknsid25:fix/handle-missing-argument

Conversation

@ysknsid25

Copy link
Copy Markdown
Contributor

If there is no argument, performing an early return is more performant.
There is no need to unnecessarily execute:

  • getArgumentType()
  • services.getTypeAtLocation(argument)
  • if (type && isClassOrFunctionType(type)) return

Signed-off-by: ysknsid25 <kengo071225@gmail.com>

@veritem veritem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@veritem
veritem merged commit ef70063 into vitest-dev:main Aug 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants