Repository navigation
feat: basic suite modes (skip, todo, only*) - #1
Merged
Merged
Conversation
patak-cat
commented
Dec 3, 2021
1 task
6 tasks done
@vitest/browser
@vitest/coverage-istanbul
@vitest/coverage-v8
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
mdong1909
pushed a commit
to mdong1909/vitest
that referenced
this pull request
Dec 23, 2025
fix: update favicon
Closed
6 tasks done
4 tasks done
6 tasks done
blitzy Bot
referenced
this pull request
in blitzy-research/vitest
Jul 16, 2026
The eight scalar sequence.* validators (shardStrategy, durationSmoothing, durationFallbackStrategy, durationHistoryTTL, durationHistoryMaxRuns, rebalanceThreshold, isolateSlowThreshold, durationHistoryPath) interpolated the raw invalid value directly into their error-message template literals. When a Symbol reached a validator (via untyped JS config or an 'as any' cast), template-literal interpolation threw the opaque engine error 'TypeError: Cannot convert a Symbol value to a string', masking the intended descriptive 'Invalid sequence.<key>' message. Wrap each interpolated value with String(), mirroring the existing shardAffinityRules[].shardIndex handling. String() renders a Symbol as 'Symbol(x)' and is byte-identical to template interpolation for all other types, so error messages are unchanged for numbers, strings, null, objects, etc. Every field now reports a descriptive, key-naming error. Adds a parameterized regression test in test/config/test/public.test.ts covering all eight scalar fields. Resolves QA Issue #1 (checkpoint: packages/vitest/src/node/cli/cli-config.ts).
blitzy Bot
referenced
this pull request
in blitzy-research/vitest
Jul 16, 2026
…shard sidecar Addresses QA FINAL report findings (HEAD 516555c): Finding #1 (MINOR, blocking): the duration-aware sharding feature had bumped picomatch 4.0.3 -> 4.0.5 in pnpm-lock.yaml, contradicting the AAP's binding 'no dependency changes' rule (0.3/0.6.2/0.7) and the in-source comments that state picomatch is pinned at 4.0.3. Revert pnpm-lock.yaml to the base resolution so no dependency is added/updated. The picomatch CVEs remain mitigated in code, version-independently, via isUnsafeAffinityPattern() + AFFINITY_PICOMATCH_OPTIONS (noextglob) in shard-affinity.ts, so reverting does not reintroduce an exploitable path. The three source comments claiming 'pinned 4.0.3' are now factually accurate again. Finding #2 (INFO): document the per-shard duration-history sidecar behavior in docs/config/sequence.md (recordFileDurations 'deliberate limits'): when a run is sharded, durations are written to duration-history.shard-<i>-of-<n>.json beside the base file so each shard partitions from an identical frozen snapshot; non-sharded runs write the base file directly. Verification: tsc --noEmit, eslint, vitest build, and vitepress docs build all pass; sequencers (294) + cli + shard/record e2e (12) suites green; git diff <base> -- pnpm-lock.yaml is empty (zero dependency drift).
Open
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement basic suite modes,
skipandtodoare working (the output could be improved later).onlyis not implemented. I'll check if I can send a PR later (if you don't beat me to it)I think having these modes (especially
skipandonly) will be useful while developing the lib