Skip to content

feat: basic suite modes (skip, todo, only*) - #1

Merged
antfu merged 2 commits into
mainfrom
feat/suite-modes
Dec 3, 2021
Merged

antfu merged 2 commits into
mainfrom
feat/suite-modes

Conversation

@patak-cat

Copy link
Copy Markdown
Member

Implement basic suite modes, skip and todo are working (the output could be improved later). only is not implemented. I'll check if I can send a PR later (if you don't beat me to it)
I think having these modes (especially skip and only) will be useful while developing the lib

Comment thread src/types.ts Resolved
@pkg-pr-new

pkg-pr-new Bot commented Aug 15, 2025

Copy link
Copy Markdown
@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@1

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@1

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@1

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@1

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@1

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@1

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@1

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@1

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@1

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@1

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@1

vite-node

npm i https://pkg.pr.new/vite-node@1

vitest

npm i https://pkg.pr.new/vitest@1

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@1

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@1

commit: c1ac15c

mdong1909 pushed a commit to mdong1909/vitest that referenced this pull request Dec 23, 2025
@hi-ogawa hi-ogawa mentioned this pull request Jun 19, 2026
blitzy Bot referenced this pull request in blitzy-research/vitest Jul 16, 2026
The eight scalar sequence.* validators (shardStrategy, durationSmoothing,
durationFallbackStrategy, durationHistoryTTL, durationHistoryMaxRuns,
rebalanceThreshold, isolateSlowThreshold, durationHistoryPath) interpolated
the raw invalid value directly into their error-message template literals.
When a Symbol reached a validator (via untyped JS config or an 'as any' cast),
template-literal interpolation threw the opaque engine error
'TypeError: Cannot convert a Symbol value to a string', masking the intended
descriptive 'Invalid sequence.<key>' message.

Wrap each interpolated value with String(), mirroring the existing
shardAffinityRules[].shardIndex handling. String() renders a Symbol as
'Symbol(x)' and is byte-identical to template interpolation for all other
types, so error messages are unchanged for numbers, strings, null, objects,
etc. Every field now reports a descriptive, key-naming error.

Adds a parameterized regression test in test/config/test/public.test.ts
covering all eight scalar fields.

Resolves QA Issue #1 (checkpoint: packages/vitest/src/node/cli/cli-config.ts).
blitzy Bot referenced this pull request in blitzy-research/vitest Jul 16, 2026
…shard sidecar

Addresses QA FINAL report findings (HEAD 516555c):

Finding #1 (MINOR, blocking): the duration-aware sharding feature had bumped
picomatch 4.0.3 -> 4.0.5 in pnpm-lock.yaml, contradicting the AAP's binding
'no dependency changes' rule (0.3/0.6.2/0.7) and the in-source comments that
state picomatch is pinned at 4.0.3. Revert pnpm-lock.yaml to the base
resolution so no dependency is added/updated. The picomatch CVEs remain
mitigated in code, version-independently, via isUnsafeAffinityPattern() +
AFFINITY_PICOMATCH_OPTIONS (noextglob) in shard-affinity.ts, so reverting
does not reintroduce an exploitable path. The three source comments claiming
'pinned 4.0.3' are now factually accurate again.

Finding #2 (INFO): document the per-shard duration-history sidecar behavior
in docs/config/sequence.md (recordFileDurations 'deliberate limits'): when a
run is sharded, durations are written to duration-history.shard-<i>-of-<n>.json
beside the base file so each shard partitions from an identical frozen
snapshot; non-sharded runs write the base file directly.

Verification: tsc --noEmit, eslint, vitest build, and vitepress docs build all
pass; sequencers (294) + cli + shard/record e2e (12) suites green;
git diff <base> -- pnpm-lock.yaml is empty (zero dependency drift).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants