feat(plugin-solid): support for Solid v2 by chenjiahan · Pull Request #7608 · web-infra-dev/rsbuild

chenjiahan · 2026-05-06T11:10:44Z

Summary

This draft PR tracks the development of @rsbuild/plugin-solid v2 for Solid v2. The stable v1 plugin remains on main, while solid-next is used for v2 prereleases.

Current status

Released @rsbuild/plugin-solid@2.0.0-beta.1 with initial Solid v2 RC support.
Updated the Solid dependencies and replaced solid-refresh with a refresh loader based on @dom-expressions/compiler.
Updated the Solid templates, example, and e2e fixtures to use @solidjs/web.

Next steps

Continue adapting to Solid v2 RC and implementing the remaining features and tests. Once v2 is ready for stable use, create solid-1.x for v1 maintenance, merge solid-next into main, and publish v2 under the latest tag.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08bfdeb945

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

gemini-code-assist

Code Review

This pull request migrates the Solid.js plugin and templates to support Solid v2 beta, which involves updating imports to @solidjs/web and adjusting dependency versions. Additionally, the project is upgraded to pnpm v11 and workspace build settings are modified in pnpm-workspace.yaml. Reviewer feedback recommends using less restrictive version ranges (using the caret ^) for Solid-related dependencies and peer dependencies to ensure compatibility with the final v2 release.

Copilot

Pull request overview

This PR updates the Solid-related ecosystem in the repo to target Solid v2 (beta) by switching runtime imports to @solidjs/web and aligning dependencies across templates, examples, and e2e coverage. It also updates the workspace/tooling baseline by bumping pnpm and refreshing the lockfile/config.

Changes:

Update Solid runtime imports from solid-js/web to @solidjs/web in templates, examples, and e2e cases.
Bump Solid-related dependencies (e.g. solid-js, @solidjs/web, babel-preset-solid, solid-refresh) to Solid v2 beta-compatible ranges.
Update pnpm tooling/config (packageManager/engines, workspace settings, lockfile format).

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pnpm-workspace.yaml	Adds pnpm workspace settings related to builds and release-age exclusions.
pnpm-lock.yaml	Updates lockfile for pnpm 11 and Solid v2 dependency graph changes.
packages/plugin-solid/package.json	Updates plugin version and Solid v2-related dependency/peerDependency declarations.
packages/create-rsbuild/template-solid-ts/src/index.tsx	Switches Solid render import to `@solidjs/web`.
packages/create-rsbuild/template-solid-ts/package.json	Updates Solid dependencies to v2 beta ranges and adds `@solidjs/web`.
packages/create-rsbuild/template-solid-js/src/index.jsx	Switches Solid render import to `@solidjs/web`.
packages/create-rsbuild/template-solid-js/package.json	Updates Solid dependencies to v2 beta ranges and adds `@solidjs/web`.
package.json	Bumps pnpm version/engine requirement.
examples/solid/src/index.jsx	Switches Solid render import to `@solidjs/web`.
examples/solid/package.json	Updates Solid dependencies to v2 beta ranges and adds `@solidjs/web`.
e2e/package.json	Updates Solid dependencies for e2e to v2 beta ranges and adds `@solidjs/web`.
e2e/cases/plugin-solid/ts/src/index.ts	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/stylus/src/index.js	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/scss/src/index.js	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/ref/src/index.jsx	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/less/src/index.js	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/hmr/src/index.jsx	Switches Solid render import to `@solidjs/web`.
e2e/cases/plugin-solid/basic/src/index.js	Switches Solid render import to `@solidjs/web`.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

birkskyum · 2026-05-06T20:33:14Z

cc @brenelz

cloudflare-workers-and-pages · 2026-08-17T02:39:39Z

Deploying rsbuild with Cloudflare Pages

Latest commit:	`b0d3962`
Status:	✅ Deploy successful!
Preview URL:	https://2cd2d356.rsbuild-v2.pages.dev
Branch Preview URL:	https://solid-next.rsbuild-v2.pages.dev

View logs

# Conflicts: # packages/create-rsbuild/template-solid-js/package.json # packages/create-rsbuild/template-solid-ts/package.json

SoonIter · 2026-08-19T01:12:29Z

<agent: daily-job rstack ecosystem-ci>

Ecosystem CI regression: `rsbuild/rslib`

Attribution: Confirmed source

Impact: Rslib's solid-component-bundle example can no longer resolve @solidjs/web after ecosystem CI injects the selected Rsbuild workspace packages.

Why this PR

This PR changes @rsbuild/plugin-solid to the Solid 2 toolchain and adds peer requirements for @solidjs/web@^2.0.0-rc.0 and solid-js@^2.0.0-rc.0. Ecosystem CI replaces the downstream fixture's Rsbuild packages with this workspace build, while the Rslib fixture still declares Solid 1 and does not install @solidjs/web; the generated code therefore imports a package absent from its graph. The immediately preceding Rsbuild run passed the same Rslib suite, and the exact missing-module signature starts at this merge.

Suggested next step

The Rslib/example owner should migrate the fixture atomically to Solid 2 and add @solidjs/web, or the ecosystem override should avoid injecting an incompatible major plugin into Solid 1 consumers. Verify the focused solid-component-bundle build and pnpm test --stack rsbuild rslib.

Evidence and attribution checks

Current run/job: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/32146764819/job/95742302169
Tested upstream: rsbuild at 0ea4a17b42820619f414feeebba4205bafeb10b1
First bad: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/32120814310/job/95660589937 at merge 54ef75a6c11de7a63a0c7ad931ff939f2f56b151
Previous good: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/32114444506/job/95640703043
Failure signature: generated Solid output imports @solidjs/web; resolution fails in both src/index.tsx and CounterButton/index.tsx
Flaky/pre-existing check: not present before this merge and deterministic across later rows
Config check: not applicable; this is a package/peer graph incompatibility
Alternatives ruled out: the Rslib repository had no commits in the green-to-red window; the source PR itself changes the plugin major and peer requirements

chenjiahan added 6 commits May 6, 2026 17:55

chore(deps): upgrade pnpm to v11

3ccdbc6

fix

5319ee7

fix

6fc70d0

fix

131caf3

chore(deps): update Solid dependencies for next

611ed30

release: @rsbuild/plugin-solid 2.0.0-alpha.0

08bfdeb

Copilot AI review requested due to automatic review settings May 6, 2026 11:10

github-actions Bot added the release: feature label May 6, 2026

Merge branch 'main' into solid-next

8af7d52

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

Comment thread packages/create-rsbuild/template-solid-js/package.json Outdated

gemini-code-assist Bot reviewed May 6, 2026

View reviewed changes

Comment thread packages/plugin-solid/package.json Outdated

Comment thread packages/plugin-solid/package.json Outdated

Comment thread packages/create-rsbuild/template-solid-js/package.json Outdated

Comment thread packages/create-rsbuild/template-solid-ts/package.json Outdated

Copilot AI reviewed May 6, 2026

View reviewed changes

fix: spell

ede7a40

chenjiahan had a problem deploying to npm May 6, 2026 13:14 — with GitHub Actions Failure

chenjiahan temporarily deployed to npm May 6, 2026 13:18 — with GitHub Actions Inactive

release: 2.0.0-beta.0

8931af5

Copilot AI review requested due to automatic review settings May 6, 2026 13:22

Copilot started reviewing on behalf of chenjiahan May 6, 2026 13:23

View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread packages/plugin-solid/package.json

Comment thread packages/plugin-solid/package.json Outdated

chenjiahan marked this pull request as draft May 6, 2026 13:46

elecmonkey mentioned this pull request Jun 30, 2026

feat(create-rslib): add Solid template and related documents web-infra-dev/rslib#1731

Merged

2 tasks done

Merge branch 'main' into solid-next

7c9aa86

Merge remote-tracking branch 'origin/main' into chenjiahan/solid-v2-rc

b0d3962

# Conflicts: # packages/create-rsbuild/template-solid-js/package.json # packages/create-rsbuild/template-solid-ts/package.json

chenjiahan mentioned this pull request Aug 18, 2026

feat(plugin-solid): support Solid v2 RC #8301

Merged

chenjiahan added 3 commits August 18, 2026 16:07

feat(plugin-solid): support Solid v2 RC (#8301)

47dcc00

release: @rsbuild/plugin-solid v2.0.0-beta.1 (#8302)

910590e

fix(create-rsbuild): correct Solid JSX import source (#8303)

4754257

chenjiahan mentioned this pull request Aug 18, 2026

docs: document Solid v2 usage #8304

Merged

chenjiahan marked this pull request as ready for review August 18, 2026 09:07

chenjiahan merged commit 54ef75a into main Aug 18, 2026
7 checks passed

chenjiahan deleted the solid-next branch August 18, 2026 09:17

chenjiahan mentioned this pull request Aug 18, 2026

feat(create-rsbuild): add Solid 2 templates #8306

Merged

Conversation

chenjiahan commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Current status

Next steps

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

birkskyum commented May 6, 2026

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rsbuild with Cloudflare Pages

Uh oh!

Uh oh!

SoonIter commented Aug 19, 2026

Ecosystem CI regression: rsbuild/rslib

Why this PR

Suggested next step

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chenjiahan commented May 6, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Aug 17, 2026 •

edited

Loading

Ecosystem CI regression: `rsbuild/rslib`