Repository navigation
perf(core): cache loadBundle stats projection - #8343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loading different entries from the same compilation currently serializes the same stats subset for every entry. This PR caches that projection in a
WeakMapkeyed byStats, avoiding repeatedtoJsoncalls while allowing previous compilations to be garbage-collected.Performance
Benchmark using a real Rspack
Statsfrom a 50-entry compilation on Node.js v24.12.0 (darwin-arm64), with 10 warmups and 30 samples:The number of stats projections per sample drops from 50 to 1. This measures only the stats projection stage, not complete bundle execution.