Repository navigation
Fix issue: 165: Disable Animations - #406
Merged
Merged
Conversation
Collaborator
|
Hey, good change thanks, could you use |
waffles-dev
requested changes
Oct 24, 2025
Fixed an issue where animations were disabled when the application first launched, even though the 'Disable Animations' setting was turned off in the config. The problem occurred because the animation state check only ran when there was a change in the setting. On first launch, since the value remained false (animations enabled), the comparison would be: lastAnimationState (false) !== currentState (false) = false This meant updateAnimationClass() was never called initially, leaving animations disabled by default. Solution: Initialize lastAnimationState as undefined instead of reading from config. This ensures the first check always triggers: lastAnimationState (undefined) !== currentState (false) = true Now animations are correctly enabled on first launch and can be toggled by the user in settings as intended. Resolves #165
Collaborator
|
Happy with changes - thank you for making them |
chevybowtie
referenced
this pull request
in chevybowtie/dosboat
Feb 15, 2026
* Fix issue: 165: Disable Animations * refactor: use setIntervalImmediately with 1000ms timer for animation toggle * refactor: simplify CSS and run prettier formatting * fix: animations disabled on first launch despite setting being off Fixed an issue where animations were disabled when the application first launched, even though the 'Disable Animations' setting was turned off in the config. The problem occurred because the animation state check only ran when there was a change in the setting. On first launch, since the value remained false (animations enabled), the comparison would be: lastAnimationState (false) !== currentState (false) = false This meant updateAnimationClass() was never called initially, leaving animations disabled by default. Solution: Initialize lastAnimationState as undefined instead of reading from config. This ensures the first check always triggers: lastAnimationState (undefined) !== currentState (false) = true Now animations are correctly enabled on first launch and can be toggled by the user in settings as intended. Resolves #165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #165 by adding a new configuration option to disable all animations in the GUI.
Changes Made
disableAnimationsboolean configuration option insrc/renderer/lib/config.tssrc/renderer/views/Config.vue) under the "General Settings" sectionsrc/renderer/App.vuethat disable all animations and transitions when the setting is enableddisable-animationsclass on the document bodyImplementation Details
The feature works by:
disable-animations) to the body element when the setting is enabledrerenderCounterpattern in the codebase)Use Case
This feature is particularly useful for users experiencing poor GPU acceleration, where animations can cause performance issues or visual glitches.
Testing
Closes #165