Repository navigation

Do not remove casts from raw types to their parameterized form - #954

Merged

timtebeek merged 1 commit into

mainfrom

tim/walla-walla

Jul 27, 2026

Merged

Do not remove casts from raw types to their parameterized form#954
timtebeek merged 1 commit into
mainfrom
tim/walla-walla

timtebeek commented Jul 27, 2026 •

edited by moderne-meeseeks Bot

Loading

Member

Fixes RemoveRedundantTypeCast removes raw-to-wildcard cast that escapes raw-type erasure #952

RemoveRedundantTypeCast removed (Box<?>) raw where raw has the raw type Box. The two types are erasure-equivalent at runtime, but the cast is required at compile time: raw-type erasure infects every member accessed on raw, so raw.items() returns raw List while ((Box<?>) raw).items() returns List<String>. Removing the cast broke compilation of downstream calls.

Now the cast is preserved when the cast type is parameterized and the expression type is a raw use of a generic type.


          Do not remove casts from raw types to their parameterized form

e38fcbd

A cast like `(Box<?>) raw` is not redundant: it re-enters the generic
type system so downstream member accesses are no longer erased.

Fixes #952

moderne-meeseeks Bot added this to OpenRewrite

moderne-meeseeks Bot assigned timtebeek

github-project-automation Bot moved this to In Progress in OpenRewrite

timtebeek merged commit e820f02 into main

1 check passed

timtebeek deleted the tim/walla-walla branch

July 27, 2026 09:42

github-project-automation Bot moved this from In Progress to Done in OpenRewrite

mergify Bot added a commit to robfrank/linklift that referenced this pull request


          chore(deps): bump org.openrewrite.recipe:rewrite-static-analysis from…

df957f9

… 2.39.0 to 2.40.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.39.0 to 2.40.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).*

> 2.40.0
> ------
>
> What's Changed
> --------------
>
> * Retain UnnecessaryThrows on overridable methods ([#939](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/939)) by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#940](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/940)
> * Qualify `this` for outer-class methods in ReplaceLambdaWithMethodReference by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#942](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/942)
> * FixStringFormatExpressions: don't strip args with no matched specifiers by [`@neil-mushell`](https://github.com/neil-mushell) in [openrewrite/rewrite-static-analysis#943](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/943)
> * UnnecessaryExplicitTypeArguments: retain load-bearing witness in argument position on instance methods too by [`@neil-mushell`](https://github.com/neil-mushell) in [openrewrite/rewrite-static-analysis#946](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/946)
> * Set Develocity `projectId` to "openrewrite" by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#947](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/947)
> * Add recipe for finding public methods missing javadoc by [`@sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-static-analysis#948](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/948)
> * Add recipes for migrating off a variety of legacy collection types by [`@sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-static-analysis#949](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/949)
> * exception-without-cause by [`@sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-static-analysis#950](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/950)
> * Do not wrap operators onto a new line in Kotlin sources by [`@vlsi`](https://github.com/vlsi) in [openrewrite/rewrite-static-analysis#936](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/936)
> * Do not remove casts from raw types to their parameterized form by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#954](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/954)
> * Forward Code Genome Project publish credentials to `ci-gradle.yml` by [`@jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-static-analysis#955](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/955)
>
> New Contributors
> ----------------
>
> * [`@neil-mushell`](https://github.com/neil-mushell) made their first contribution in [openrewrite/rewrite-static-analysis#943](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/943)
> * [`@vlsi`](https://github.com/vlsi) made their first contribution in [openrewrite/rewrite-static-analysis#936](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/936)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.39.0...v2.40.0>


Commits

* [`00641d2`](openrewrite/rewrite-static-analysis@00641d2) Forward Code Genome Project publish credentials to `ci-gradle.yml` ([#955](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/955))
* [`95224f1`](openrewrite/rewrite-static-analysis@95224f1) Fix test
* [`39215cf`](openrewrite/rewrite-static-analysis@39215cf) Trim data table input
* [`e820f02`](openrewrite/rewrite-static-analysis@e820f02) Do not remove casts from raw types to their parameterized form ([#954](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/954))
* [`5545efa`](openrewrite/rewrite-static-analysis@5545efa) Do not wrap operators onto a new line in Kotlin sources ([#936](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/936))
* [`8a88b48`](openrewrite/rewrite-static-analysis@8a88b48) exception-without-cause ([#950](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/950))
* [`9188c13`](openrewrite/rewrite-static-analysis@9188c13) Add recipes for migrating off a variety of legacy collection types ([#949](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/949))
* [`bcf245c`](openrewrite/rewrite-static-analysis@bcf245c) Add recipe for finding public methods missing javadoc ([#948](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/948))
* [`8e4b8c8`](openrewrite/rewrite-static-analysis@8e4b8c8) Set Develocity `projectId` to "openrewrite" ([#947](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/947))
* [`13da514`](openrewrite/rewrite-static-analysis@13da514) Move Develocity to community.develocity.cloud
* Additional commits viewable in [compare view](openrewrite/rewrite-static-analysis@v2.39.0...v2.40.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.39.0&new-version=2.40.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet