Repository navigation
fix(webui): sync package-lock.json for qrcode dependency - #4927
Merged
Merged
Conversation
fe0717b ("feat(webui): add guided setup flows") added qrcode and @types/qrcode to webui/package.json without regenerating the lockfile, so `npm ci` fails in the Docker build with EUSAGE (Missing: qrcode, @types/qrcode, dijkstrajs, pngjs, yargs, ...). Regenerate the lockfile so it matches package.json again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
|
thanks for reporting this |
chengyongru
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fe0717b3("feat(webui): add guided setup flows") addedqrcodeand@types/qrcodetowebui/package.jsonbut did not regeneratewebui/package-lock.json. As a resultnpm cifails in the Docker build:Fix
Regenerate
webui/package-lock.jsonso it matchespackage.json(
npm install --package-lock-only). Verifiednpm cinow exits 0 onnode:24-bookworm-slim(the image used by the Docker build).Note: this is a recurrence
This is the second time this exact class of breakage has landed. It was
previously fixed in #4863 (
e2845926, "fix(webui): sync package-lock.json toresolve docker build failure", merged 2026-07-10), then reintroduced 3 days
later by
fe0717b3.To stop it recurring, consider adding an
npm cistep to CI on PRs that touchwebui/(e.g.cd webui && npm ci).npm cifails hard whenpackage.jsonandpackage-lock.jsondrift, so it would catch this class ofbug before merge — whereas
npm installwould silently paper over it.