Skip to content

fix(webui): sync package-lock.json for qrcode dependency - #4927

Merged
chengyongru merged 2 commits into
HKUDS:mainfrom
3L1AS:fix/webui-lockfile-sync
Jul 14, 2026
Merged

chengyongru merged 2 commits into
HKUDS:mainfrom
3L1AS:fix/webui-lockfile-sync

Conversation

@3L1AS

@3L1AS 3L1AS commented Jul 14, 2026 •

Copy link
Copy Markdown

Problem

fe0717b3 ("feat(webui): add guided setup flows") added qrcode and
@types/qrcode to webui/package.json but did not regenerate
webui/package-lock.json. As a result npm ci fails in the Docker build:

npm error code EUSAGE
npm error `npm ci` can only install packages when your package.json and
npm error package-lock.json are in sync.
npm error Missing: qrcode@..., @types/qrcode@..., dijkstrajs, pngjs, yargs, ...

Fix

Regenerate webui/package-lock.json so it matches package.json
(npm install --package-lock-only). Verified npm ci now exits 0 on
node:24-bookworm-slim (the image used by the Docker build).

Note: this is a recurrence

This is the second time this exact class of breakage has landed. It was
previously fixed in #4863 (e2845926, "fix(webui): sync package-lock.json to
resolve docker build failure", merged 2026-07-10), then reintroduced 3 days
later by fe0717b3.

To stop it recurring, consider adding an npm ci step to CI on PRs that touch
webui/ (e.g. cd webui && npm ci). npm ci fails hard when
package.json and package-lock.json drift, so it would catch this class of
bug before merge — whereas npm install would silently paper over it.

fe0717b ("feat(webui): add guided setup flows") added qrcode and
@types/qrcode to webui/package.json without regenerating the lockfile,
so `npm ci` fails in the Docker build with EUSAGE (Missing: qrcode,
@types/qrcode, dijkstrajs, pngjs, yargs, ...).

Regenerate the lockfile so it matches package.json again.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@chengyongru chengyongru added priority: p2 Normal backlog: minor bug, enhancement, docs, cleanup, edge case, or unvalidated proposal. fix webui labels Jul 14, 2026
@chengyongru

Copy link
Copy Markdown
Collaborator

thanks for reporting this

@chengyongru
chengyongru merged commit 905da8e into HKUDS:main Jul 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix priority: p2 Normal backlog: minor bug, enhancement, docs, cleanup, edge case, or unvalidated proposal. webui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants