[KingInYellow18]

Final closure gate for the EveryInc merge effort. Adds docs/operations/post-w3-functional-smoke-test.md with a written checklist exercising the actual plugin behaviors Wave 3 added (review:pr end-to-end, docs:review end-to-end, debt:audit v2.0 schema confirmation, W3 #5 auto-trigger). Reuses Section 3 sign-off format from release-checklist.md verbatim. No changeset (docs-only, not in plugins/).

Summary

Stack context

Test plan

Notes for reviewers

Greptile Summary

This PR adds docs/operations/post-w3-functional-smoke-test.md as the required closure gate for the EveryInc merge effort, substantially rewrites AGENTS.md with new sections covering manifest rules, hook authoring, and an agent audit checklist, appends a Stack Progress block to the merge plan, and deletes the binary RESEARCH/MERGE_PLAN.md.docx.

• Smoke test document: New standalone checklist covering four Wave 3 acceptance checks. Several correctness issues flagged in earlier review rounds remain unresolved (blank sign-off, wrong PR reference in Failure Handling, broken MEMORY.md link, plugin count discrepancy, and gh pr list --search 'plugins/' not matching by changed-file path); the C.3 schema-verification step can also silently pass when the findings array is empty.
• AGENTS.md: Expanded from ~156 to ~306 lines with new sections for plugin manifests, hook authoring, documentation expectations, and a pre-change audit checklist. Content quality is high.
• plans/everyinc-merge-remaining-work.md: Stack Progress block records PR docs(operations): post-W3 functional smoke test checklist #412 as completed before it has merged, misleading automated agents reading the plan.

Confidence Score: 3/5

Not safe to merge: multiple substantive issues in the smoke-test document and merge plan remain unresolved from prior review rounds.

The smoke-test document — described as the required closure gate — contains several unresolved defects: blank sign-off (gate never executed), wrong PR number in Failure Handling (#411 instead of #412), broken MEMORY.md reference, plugin count mismatch (17 vs 18 in AGENTS.md), and a gh search step that won't match by changed-file path. The merge plan also marks this open PR as already completed, which would cause automated workflows to skip the gate entirely.

docs/operations/post-w3-functional-smoke-test.md and plans/everyinc-merge-remaining-work.md both need attention before merge.

Important Files Changed

Filename	Overview
AGENTS.md	Comprehensive rewrite expanding AGENTS.md from ~156 to ~306 lines; adds Purpose & Source Of Truth, Targeted Validation Matrix, Plugin Manifest Rules, Hook Authoring Rules, Documentation Expectations, and Audit Checklist for Agents sections. Content is well-structured and accurate.
docs/operations/post-w3-functional-smoke-test.md	New functional smoke-test checklist serving as the EveryInc merge closure gate. Multiple issues from prior review remain unresolved: blank sign-off block, incorrect PR number in Failure Handling, broken MEMORY.md reference, plugin count mismatch (17 vs 18), and gh search syntax won't match file paths. New finding: C.3 schema verification silently passes on empty findings.
plans/everyinc-merge-remaining-work.md	Appends Stack Progress tracking block. Records PR #412 (this very open PR) as completed 2026-05-06, misrepresenting merge state to automated agents.
RESEARCH/MERGE_PLAN.md.docx	Binary docx file deleted. No concerns.

Comments Outside Diff (3)

1. plans/everyinc-merge-remaining-work.md, line 667 (link)

   Stack progress marks this PR complete before it is merged

   Item 5 records PR docs(operations): post-W3 functional smoke test checklist #412 as "completed 2026-05-06", but docs(operations): post-W3 functional smoke test checklist #412 is this very PR, currently open and under review. Any agent (e.g. /workflows:work) that reads this plan to decide whether the smoke-test gate is closed will see it as done and may proceed with merge-effort finalisation even though the test has not been run and the PR has not landed.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: plans/everyinc-merge-remaining-work.md
   Line: 667
   
   Comment:
   **Stack progress marks this PR complete before it is merged**
   
   Item 5 records PR #412 as "completed 2026-05-06", but #412 is this very PR, currently open and under review. Any agent (e.g. `/workflows:work`) that reads this plan to decide whether the smoke-test gate is closed will see it as done and may proceed with merge-effort finalisation even though the test has not been run and the PR has not landed.
   
   How can I resolve this? If you propose a fix, please make it concise.

   

2. docs/operations/post-w3-functional-smoke-test.md, line 492 (link)

   Plugin count out of sync with AGENTS.md

   The smoke test expects 17 plugins in the marketplace, but the updated AGENTS.md in this same PR lists 18 plugin directories: gt-workflow, yellow-browser-test, yellow-chatprd, yellow-ci, yellow-codex, yellow-composio, yellow-core, yellow-council, yellow-debt, yellow-devin, yellow-docs, yellow-linear, yellow-mempalace, yellow-morph, yellow-research, yellow-review, yellow-ruvector, and yellow-semgrep. An executor running this checklist on the installed marketplace will see 18 and will not know whether the test is wrong or whether a plugin is unexpectedly missing.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: docs/operations/post-w3-functional-smoke-test.md
   Line: 492
   
   Comment:
   **Plugin count out of sync with AGENTS.md**
   
   The smoke test expects 17 plugins in the marketplace, but the updated AGENTS.md in this same PR lists 18 plugin directories: `gt-workflow`, `yellow-browser-test`, `yellow-chatprd`, `yellow-ci`, `yellow-codex`, `yellow-composio`, `yellow-core`, `yellow-council`, `yellow-debt`, `yellow-devin`, `yellow-docs`, `yellow-linear`, `yellow-mempalace`, `yellow-morph`, `yellow-research`, `yellow-review`, `yellow-ruvector`, and `yellow-semgrep`. An executor running this checklist on the installed marketplace will see 18 and will not know whether the test is wrong or whether a plugin is unexpectedly missing.
   
   How can I resolve this? If you propose a fix, please make it concise.

   

3. plans/everyinc-merge-remaining-work.md, line 437-438 (link)

   Delivered scope diverges from the plan's stated scope

   Stack item 5 specifies Scope: docs/operations/release-checklist.md (extend with Section 3.5), but this PR does not modify release-checklist.md at all — the checklist landed in a new standalone file (docs/operations/post-w3-functional-smoke-test.md). Any agent that reads the plan's Scope field to verify or re-run item 5 will look for Section 3.5 in release-checklist.md, find nothing, and incorrectly conclude the task is incomplete or needs re-execution. The Scope: field in the plan should be updated to reflect the actual deliverable path.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: plans/everyinc-merge-remaining-work.md
   Line: 437-438
   
   Comment:
   **Delivered scope diverges from the plan's stated scope**
   
   Stack item 5 specifies `Scope: docs/operations/release-checklist.md (extend with Section 3.5)`, but this PR does not modify `release-checklist.md` at all — the checklist landed in a new standalone file (`docs/operations/post-w3-functional-smoke-test.md`). Any agent that reads the plan's `Scope` field to verify or re-run item 5 will look for Section 3.5 in `release-checklist.md`, find nothing, and incorrectly conclude the task is incomplete or needs re-execution. The `Scope:` field in the plan should be updated to reflect the actual deliverable path.
   
   How can I resolve this? If you propose a fix, please make it concise.

   

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
docs/operations/post-w3-functional-smoke-test.md:132-137
The `jq '.findings[0] | keys'` expression returns `null` silently when `.findings` is an empty array, so the schema-verification step passes without actually confirming any v2.0 fields. A repo that happens to produce no findings on the small audit sub-corpus would give a false green here. Guard the check with a length assertion so zero findings surfaces as an explicit failure.

```suggestion
- [ ] Verify schema in any one output:
  ```bash
  jq 'if (.findings | length) == 0 then error("no findings to validate schema against") else .findings[0] | keys end' .debt/scanner-output/ai-pattern-scanner.json
  # Expected: ["category", "confidence", "effort", "failure_scenario", "file",
  #           "finding", "fix", "severity"] — all 8 v2.0 keys present
  # If the array is empty the command exits non-zero and surfaces the issue.
  ```
```

_{Reviews (10): Last reviewed commit: "docs(operations): add CLI prereqs, clari..." | Re-trigger Greptile}

[codeant-ai]

User kinginyellow18@proton.me does not have a PR Review subscription.

Go to Team management and add this email to the PR Review subscription.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a435530-b1d8-4e1c-a84b-2e1e5158383c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/chore/everyinc-merge-closure-smoke-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[KingInYellow18]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• docs(operations): post-W3 functional smoke test checklist #412 👈 (View in Graphite)
• feat(yellow-docs): /docs:review command + 7 persona reviewer agents (Wave 3 #2) #410
• feat(yellow-debt): confirm v2.0 schema emission across all 5 scanners (Wave 3 #7) #406
• feat: agent-native-reviewers + authoring skills #403
• chore: complete W2 backbone loose threads #402
• main

---

How to use the Graphite Merge Queue

Add the label graphite-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codacy-production]

Not up to standards ⛔

🔴 Issues 3 minor

Alerts:
⚠ 3 issues (≤ 0 issues of at least minor severity)

Results:
3 new issues

Category	Results
CodeStyle	3 minor

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[gemini-code-assist]

Code Review

This pull request adds a comprehensive functional smoke test document for Wave 3 deliverables and updates the stack progress tracking. The review feedback identifies the need to explicitly list required CLI tools like gh, gt, and jq as prerequisites and notes that the tests are specifically coupled to the yellow-plugins repository structure rather than being applicable to any generic git repository.

[qodo-code-review]

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

[Copilot]

Pull request overview

Adds an operations-facing, post–Wave 3 functional smoke test checklist intended to serve as the final closure gate for the EveryInc merge effort, and updates the merge plan to reflect current stack progress.

Changes:

• Add docs/operations/post-w3-functional-smoke-test.md documenting an end-to-end functional acceptance checklist across yellow-review, yellow-docs, and yellow-debt behaviors.
• Update plans/everyinc-merge-remaining-work.md with a generated “Stack Progress” section reflecting completion status of prior stacked PRs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
plans/everyinc-merge-remaining-work.md	Adds a “Stack Progress” checklist to track stacked PR completion status for the EveryInc merge effort.
docs/operations/post-w3-functional-smoke-test.md	Introduces a post-W3 smoke test runbook/checklist for validating key Wave 3 plugin behaviors on a fresh Claude Code install.

[KingInYellow18]

Merge activity

• May 7, 6:04 AM UTC: The merge label 'graphite-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 7, 6:05 AM UTC: The merge label 'graphite-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 7, 6:09 AM UTC: KingInYellow18 added this pull request to the Graphite merge queue.
• May 7, 6:11 AM UTC: CI is running for this pull request on a draft pull request (#433) due to your merge queue CI optimization settings.
• May 7, 6:11 AM UTC: Merged by the Graphite merge queue via draft PR: #433.