Skip to content

Attempt to improve vpc_subnet / vpc_net stability - #270

Merged
tremble merged 6 commits into
ansible-collections:mainfrom
tremble:stability/vpc
Mar 8, 2021
Merged

tremble merged 6 commits into
ansible-collections:mainfrom
tremble:stability/vpc

Conversation

@tremble

@tremble tremble commented Feb 25, 2021 •

Copy link
Copy Markdown
Contributor
SUMMARY

Over in community.aws we're seeing repeated failures due to API rate limits with the subnet/net changes (mostly waiter related)
Switch to a custom waiter that knows how to cope with the API Rate limits.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_subnet
ec2_vpc_net

ADDITIONAL INFORMATION

Will push changelog once tests complete

@ansibullbot

Copy link
Copy Markdown

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) labels Feb 25, 2021
@tremble tremble removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 25, 2021

@alinabuzachis alinabuzachis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tremble for asking me to review.

Comment thread plugins/module_utils/waiters.py Resolved
Comment thread plugins/module_utils/waiters.py Resolved
Comment thread plugins/module_utils/waiters.py Resolved
Comment thread plugins/modules/ec2_vpc_net.py Resolved
Comment thread plugins/modules/ec2_vpc_net.py Resolved
Comment thread plugins/modules/ec2_vpc_net.py Resolved
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 4, 2021
@tremble
tremble requested a review from alinabuzachis March 6, 2021 13:52
@tremble

tremble commented Mar 6, 2021

Copy link
Copy Markdown
Contributor Author

@alinabuzachis For what it's worth I did dig into what it would take to tune the botocore waiters

In theory we could do so by using botocore.client.BaseClient._get_waiter_config() (client._get_waiter_config) however, as an _ method that leaves us reliant on a non-public interface, which I don't think would be a good idea.

This leaves is with copying the waiter configs we care about into waiters.py as the only sane way to inject retrying on API rate limits.

@alinabuzachis

Copy link
Copy Markdown
Collaborator

@alinabuzachis For what it's worth I did dig into what it would take to tune the botocore waiters

In theory we could do so by using botocore.client.BaseClient._get_waiter_config() (client._get_waiter_config) however, as an _ method that leaves us reliant on a non-public interface, which I don't think would be a good idea.

This leaves is with copying the waiter configs we care about into waiters.py as the only sane way to inject retrying on API rate limits.

@tremble Thank you for explaining. It makes sense to me. I am going to add a waiter even for NatGatewayAvailable since I used the built-in one. https://github.com/ansible-collections/community.aws/pull/445/files#diff-847118175f7fbd015daf612a3319157ca22874f706c01f26348f4f86f67384d9R706-R709

@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 8, 2021
Comment thread plugins/module_utils/waiters.py Resolved
@tremble

tremble commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

Change approved and Shippable tests passing. Merging

@tremble
tremble merged commit c89b3fc into ansible-collections:main Mar 8, 2021
@tremble
tremble deleted the stability/vpc branch May 28, 2021 07:08
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ble-collections#270)

* Add additional storage classes to S3 lifecycle transition list.
* Add minor changes changelog for S3 lifecycle transition list change.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ble-collections#270)

* Add additional storage classes to S3 lifecycle transition list.
* Add minor changes changelog for S3 lifecycle transition list change.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ble-collections#270)

* Add additional storage classes to S3 lifecycle transition list.
* Add minor changes changelog for S3 lifecycle transition list change.
centosinfra-prod-github-app Bot pushed a commit that referenced this pull request Oct 8, 2026
…ates (#3148)

Bumps the github-actions group with 2 updates in the / directory: dawidd6/action-download-artifact and SonarSource/sonarqube-scan-action.
Updates dawidd6/action-download-artifact from 25 to 27

Release notes
Sourced from dawidd6/action-download-artifact's releases.

v27
What's Changed

fix: merge unfiltered runs into filtered run search by @​dawidd6 in dawidd6/action-download-artifact#432

Full Changelog: dawidd6/action-download-artifact@v26...v27
v26
Full Changelog: dawidd6/action-download-artifact@v25...v26



Commits

eab87c9 fix: merge unfiltered runs into filtered run search (#432)
27e4ae6 feat: log skipped workflow runs in debug mode
See full diff in compare view



Updates SonarSource/sonarqube-scan-action from 8.2.2 to 8.3.0

Release notes
Sourced from SonarSource/sonarqube-scan-action's releases.

v8.3.0
What's Changed

Fix GPG key retrieval through HTTPS proxies by @​Torbjorn-Svensson in SonarSource/sonarqube-scan-action#265
Configure Renovate by @​renovate[bot] in SonarSource/sonarqube-scan-action#267
SQSCANGHA-168 Update actions/cache action to v5.1.0 by @​renovate[bot] in SonarSource/sonarqube-scan-action#269
Update npm dependencies by @​renovate[bot] in SonarSource/sonarqube-scan-action#268
Update dependency @​actions/exec to v3 by @​renovate[bot] in SonarSource/sonarqube-scan-action#270
Update GitHub Actions dependencies (major) by @​renovate[bot] in SonarSource/sonarqube-scan-action#271

New Contributors

@​Torbjorn-Svensson made their first contribution in SonarSource/sonarqube-scan-action#265
@​renovate[bot] made their first contribution in SonarSource/sonarqube-scan-action#267

Full Changelog: SonarSource/sonarqube-scan-action@v8.2.2...v8.3.0



Commits

d209202 Update GitHub Actions dependencies (major) (#271)
0333cb3 Update dependency @​actions/exec to v3 (#270)
da4450e Update npm dependencies (#268)
c5094d1 SQSCANGHA-168 Update actions/cache action to v5.1.0 (#269)
001613f SQSCANGHA-162 Configure Renovate (#267)
6abe0a7 SQSCANGHA-165 Fix GPG key retrieval through HTTPS proxies (#265)
See full diff in compare view



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Reviewed-by: Don Naro <dnaro@redhat.com>
Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community_review feature This issue/PR relates to a feature request module_utils module_utils module module plugins plugin (any type)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants