Repository navigation
Attempt to improve vpc_subnet / vpc_net stability - #270
Conversation
67a51b0 to
8805d02
Compare
alinabuzachis
left a comment
There was a problem hiding this comment.
Thank you @tremble for asking me to review.
|
@alinabuzachis For what it's worth I did dig into what it would take to tune the botocore waiters In theory we could do so by using This leaves is with copying the waiter configs we care about into waiters.py as the only sane way to inject retrying on API rate limits. |
@tremble Thank you for explaining. It makes sense to me. I am going to add a waiter even for NatGatewayAvailable since I used the built-in one. https://github.com/ansible-collections/community.aws/pull/445/files#diff-847118175f7fbd015daf612a3319157ca22874f706c01f26348f4f86f67384d9R706-R709 |
|
Change approved and Shippable tests passing. Merging |
…ble-collections#270) * Add additional storage classes to S3 lifecycle transition list. * Add minor changes changelog for S3 lifecycle transition list change.
…ble-collections#270) * Add additional storage classes to S3 lifecycle transition list. * Add minor changes changelog for S3 lifecycle transition list change.
…ble-collections#270) * Add additional storage classes to S3 lifecycle transition list. * Add minor changes changelog for S3 lifecycle transition list change.
…ates (#3148) Bumps the github-actions group with 2 updates in the / directory: dawidd6/action-download-artifact and SonarSource/sonarqube-scan-action. Updates dawidd6/action-download-artifact from 25 to 27 Release notes Sourced from dawidd6/action-download-artifact's releases. v27 What's Changed fix: merge unfiltered runs into filtered run search by @dawidd6 in dawidd6/action-download-artifact#432 Full Changelog: dawidd6/action-download-artifact@v26...v27 v26 Full Changelog: dawidd6/action-download-artifact@v25...v26 Commits eab87c9 fix: merge unfiltered runs into filtered run search (#432) 27e4ae6 feat: log skipped workflow runs in debug mode See full diff in compare view Updates SonarSource/sonarqube-scan-action from 8.2.2 to 8.3.0 Release notes Sourced from SonarSource/sonarqube-scan-action's releases. v8.3.0 What's Changed Fix GPG key retrieval through HTTPS proxies by @Torbjorn-Svensson in SonarSource/sonarqube-scan-action#265 Configure Renovate by @renovate[bot] in SonarSource/sonarqube-scan-action#267 SQSCANGHA-168 Update actions/cache action to v5.1.0 by @renovate[bot] in SonarSource/sonarqube-scan-action#269 Update npm dependencies by @renovate[bot] in SonarSource/sonarqube-scan-action#268 Update dependency @actions/exec to v3 by @renovate[bot] in SonarSource/sonarqube-scan-action#270 Update GitHub Actions dependencies (major) by @renovate[bot] in SonarSource/sonarqube-scan-action#271 New Contributors @Torbjorn-Svensson made their first contribution in SonarSource/sonarqube-scan-action#265 @renovate[bot] made their first contribution in SonarSource/sonarqube-scan-action#267 Full Changelog: SonarSource/sonarqube-scan-action@v8.2.2...v8.3.0 Commits d209202 Update GitHub Actions dependencies (major) (#271) 0333cb3 Update dependency @actions/exec to v3 (#270) da4450e Update npm dependencies (#268) c5094d1 SQSCANGHA-168 Update actions/cache action to v5.1.0 (#269) 001613f SQSCANGHA-162 Configure Renovate (#267) 6abe0a7 SQSCANGHA-165 Fix GPG key retrieval through HTTPS proxies (#265) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions Reviewed-by: Don Naro <dnaro@redhat.com> Reviewed-by: Bikouo Aubin
SUMMARY
Over in community.aws we're seeing repeated failures due to API rate limits with the subnet/net changes (mostly waiter related)
Switch to a custom waiter that knows how to cope with the API Rate limits.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_subnet
ec2_vpc_net
ADDITIONAL INFORMATION
Will push changelog once tests complete