Skip to content

new helper function : normalize_boto3_result - #271

Merged
jillr merged 3 commits into
ansible-collections:mainfrom
tremble:boto3_normalize
Mar 10, 2021
Merged

jillr merged 3 commits into
ansible-collections:mainfrom
tremble:boto3_normalize

Conversation

@tremble

@tremble tremble commented Feb 28, 2021 •

Copy link
Copy Markdown
Contributor
SUMMARY

We have a number of modules using JSON round-tripping to convert dates into ISO-formatted strings. Move this into a common helper.

Right now this only does something unusual to datetime resources, but it's been left generic in case something else is needed (Booleans?)

Todo:

  • Changelog
  • Unit tests
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

plugins/module_utils/core.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added WIP Work in progress module_utils module_utils needs_triage new_plugin New plugin plugins plugin (any type) labels Feb 28, 2021
@ansibullbot ansibullbot removed the new_plugin New plugin label Feb 28, 2021
@tremble
tremble requested a review from jillr February 28, 2021 20:40
@tremble

tremble commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

@jillr Stealing the logic from multiple community modules (because I need it in yet another one):

  • ec2_customer_gateway_info
  • ec2_vpc_endpoint
  • ec2_vpc_endpoint_info
  • ec2_vpc_peering_info
  • ec2_vpc_vpn_info
  • ec2_vpc_nat_gateway_info

Before I sit down and write unit tests, any objections?

@ansibullbot ansibullbot added the tests tests label Mar 7, 2021
@tremble tremble changed the title [WIP] new helper function : normalize_boto3_result function new helper function : normalize_boto3_result function Mar 7, 2021
@tremble tremble changed the title new helper function : normalize_boto3_result function new helper function : normalize_boto3_result Mar 7, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Mar 7, 2021
@jillr

jillr commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

@tremble I like the idea of this, I've run across it several times recently myself. I see the unit test but wanted to be sure that's what your previous comment referred to - is this one ready?

@tremble

tremble commented Mar 10, 2021 •

Copy link
Copy Markdown
Contributor Author

This is ready for review. I initially pushed this before my first absence this month and wanted to get your opinion on pulling this code into module_utils.

Decided to just get the unit tests written in the end. They're not 100% comprehensive, but they can be expanded if we find gaps.

@jillr
jillr merged commit c4bcc88 into ansible-collections:main Mar 10, 2021
@tremble
tremble deleted the boto3_normalize branch May 28, 2021 07:08
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Ansible 2.9 has a test constraint for openshift >= 0.6.2, < 0.9.0.
We're only specifying a minimum boto3 today and 1.16.x has released,
which pulls in a newer urllib3 than that openshift supports.
centosinfra-prod-github-app Bot pushed a commit that referenced this pull request Oct 8, 2026
…ates (#3148)

Bumps the github-actions group with 2 updates in the / directory: dawidd6/action-download-artifact and SonarSource/sonarqube-scan-action.
Updates dawidd6/action-download-artifact from 25 to 27

Release notes
Sourced from dawidd6/action-download-artifact's releases.

v27
What's Changed

fix: merge unfiltered runs into filtered run search by @​dawidd6 in dawidd6/action-download-artifact#432

Full Changelog: dawidd6/action-download-artifact@v26...v27
v26
Full Changelog: dawidd6/action-download-artifact@v25...v26



Commits

eab87c9 fix: merge unfiltered runs into filtered run search (#432)
27e4ae6 feat: log skipped workflow runs in debug mode
See full diff in compare view



Updates SonarSource/sonarqube-scan-action from 8.2.2 to 8.3.0

Release notes
Sourced from SonarSource/sonarqube-scan-action's releases.

v8.3.0
What's Changed

Fix GPG key retrieval through HTTPS proxies by @​Torbjorn-Svensson in SonarSource/sonarqube-scan-action#265
Configure Renovate by @​renovate[bot] in SonarSource/sonarqube-scan-action#267
SQSCANGHA-168 Update actions/cache action to v5.1.0 by @​renovate[bot] in SonarSource/sonarqube-scan-action#269
Update npm dependencies by @​renovate[bot] in SonarSource/sonarqube-scan-action#268
Update dependency @​actions/exec to v3 by @​renovate[bot] in SonarSource/sonarqube-scan-action#270
Update GitHub Actions dependencies (major) by @​renovate[bot] in SonarSource/sonarqube-scan-action#271

New Contributors

@​Torbjorn-Svensson made their first contribution in SonarSource/sonarqube-scan-action#265
@​renovate[bot] made their first contribution in SonarSource/sonarqube-scan-action#267

Full Changelog: SonarSource/sonarqube-scan-action@v8.2.2...v8.3.0



Commits

d209202 Update GitHub Actions dependencies (major) (#271)
0333cb3 Update dependency @​actions/exec to v3 (#270)
da4450e Update npm dependencies (#268)
c5094d1 SQSCANGHA-168 Update actions/cache action to v5.1.0 (#269)
001613f SQSCANGHA-162 Configure Renovate (#267)
6abe0a7 SQSCANGHA-165 Fix GPG key retrieval through HTTPS proxies (#265)
See full diff in compare view



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Reviewed-by: Don Naro <dnaro@redhat.com>
Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community_review module_utils module_utils plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants