Repository navigation
new helper function : normalize_boto3_result - #271
Merged
Merged
Conversation
Contributor
Author
|
@jillr Stealing the logic from multiple community modules (because I need it in yet another one):
Before I sit down and write unit tests, any objections? |
Contributor
|
@tremble I like the idea of this, I've run across it several times recently myself. I see the unit test but wanted to be sure that's what your previous comment referred to - is this one ready? |
Contributor
Author
|
This is ready for review. I initially pushed this before my first absence this month and wanted to get your opinion on pulling this code into module_utils. Decided to just get the unit tests written in the end. They're not 100% comprehensive, but they can be expanded if we find gaps. |
jillr
approved these changes
Mar 10, 2021
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Ansible 2.9 has a test constraint for openshift >= 0.6.2, < 0.9.0. We're only specifying a minimum boto3 today and 1.16.x has released, which pulls in a newer urllib3 than that openshift supports.
centosinfra-prod-github-app Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
…ates (#3148) Bumps the github-actions group with 2 updates in the / directory: dawidd6/action-download-artifact and SonarSource/sonarqube-scan-action. Updates dawidd6/action-download-artifact from 25 to 27 Release notes Sourced from dawidd6/action-download-artifact's releases. v27 What's Changed fix: merge unfiltered runs into filtered run search by @dawidd6 in dawidd6/action-download-artifact#432 Full Changelog: dawidd6/action-download-artifact@v26...v27 v26 Full Changelog: dawidd6/action-download-artifact@v25...v26 Commits eab87c9 fix: merge unfiltered runs into filtered run search (#432) 27e4ae6 feat: log skipped workflow runs in debug mode See full diff in compare view Updates SonarSource/sonarqube-scan-action from 8.2.2 to 8.3.0 Release notes Sourced from SonarSource/sonarqube-scan-action's releases. v8.3.0 What's Changed Fix GPG key retrieval through HTTPS proxies by @Torbjorn-Svensson in SonarSource/sonarqube-scan-action#265 Configure Renovate by @renovate[bot] in SonarSource/sonarqube-scan-action#267 SQSCANGHA-168 Update actions/cache action to v5.1.0 by @renovate[bot] in SonarSource/sonarqube-scan-action#269 Update npm dependencies by @renovate[bot] in SonarSource/sonarqube-scan-action#268 Update dependency @actions/exec to v3 by @renovate[bot] in SonarSource/sonarqube-scan-action#270 Update GitHub Actions dependencies (major) by @renovate[bot] in SonarSource/sonarqube-scan-action#271 New Contributors @Torbjorn-Svensson made their first contribution in SonarSource/sonarqube-scan-action#265 @renovate[bot] made their first contribution in SonarSource/sonarqube-scan-action#267 Full Changelog: SonarSource/sonarqube-scan-action@v8.2.2...v8.3.0 Commits d209202 Update GitHub Actions dependencies (major) (#271) 0333cb3 Update dependency @actions/exec to v3 (#270) da4450e Update npm dependencies (#268) c5094d1 SQSCANGHA-168 Update actions/cache action to v5.1.0 (#269) 001613f SQSCANGHA-162 Configure Renovate (#267) 6abe0a7 SQSCANGHA-165 Fix GPG key retrieval through HTTPS proxies (#265) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions Reviewed-by: Don Naro <dnaro@redhat.com> Reviewed-by: Bikouo Aubin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have a number of modules using JSON round-tripping to convert dates into ISO-formatted strings. Move this into a common helper.
Right now this only does something unusual to datetime resources, but it's been left generic in case something else is needed (Booleans?)
Todo:
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/core.py
ADDITIONAL INFORMATION