Skip to content

Revert "Remove misc. dead x87 code" - #6419

Merged
vijaysun-omr merged 1 commit into
masterfrom
revert-6378-noassignfpregs
Mar 17, 2022
Merged

vijaysun-omr merged 1 commit into
masterfrom
revert-6378-noassignfpregs

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

Reverts #6378

Causing 32-bit downstream project failures on Linux.

@0xdaryl

0xdaryl commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

Copyright failure is expected because this is a reversion.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

jenkins build all

@0xdaryl

0xdaryl commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

Windows and zOS failures are infrastructural.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

The failing copyright check is due to the revert, i.e. when the original PR gets re-enabled, the copyrights will be fixed up.

Since this is just a reverting of a recent change, I'm going to merge this even though we hit a couple of infra problems.

@vijaysun-omr
vijaysun-omr merged commit 644b907 into master Mar 17, 2022
@keithc-ca

Copy link
Copy Markdown
Contributor

Now that this is merged, could I request that the branch revert-6378-noassignfpregs be removed? Thanks.

@0xdaryl
0xdaryl deleted the revert-6378-noassignfpregs branch March 21, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants