Repository navigation
Remove the --gtest_filter=${porttest_filter} option for porttest - #6487
Conversation
|
|
|
jenkins build all |
@AdamBrousseau @jdekonin Are the OMR machines configured to generate core files correctly? |
|
|
|
jenkins build all |
The bulk of the existing systems in jenkins were setup prior to either @AdamBrousseau or my involvement with the OMR project. A quick spot check of a few would have me answer no, I don't believe they are and that needs an issue for deeper review. Can you please open an issue to track? |
|
If you're asking about the machines on azure, we don't own those resources. I'm not sure if we have the ability to control things like core settings on those. Someone would have to look at the azure doc. |
ec96fb5 to
68e52e0
Compare
|
I tried to add the below cmds in azure-pipelines.yml: |
c7082af to
0a13c43
Compare
|
jenkins build all |
|
With these changes,
|
When ${porttest_filter} is an empty string, no tests from porttest are
run. ${porttest_filter} is never set in OMR so it will always be an
empty string. Also, --gtest_filter=${porttest_filter} conflicts with
the GTEST_FILTER environment variable used by omrbuild.groovy. To avoid
the conflict and correctly run porttest, the --gtest_filter=${porttest_filter}
option is removed. porttest should consistently rely upon the GTEST_FILTER
environment variable.
Changed --gtest_filter="Cuda*" to --gtest_filter=*Cuda*. 0 tests are run.
This allows cuda_porttest to work correctly.
Fixes: eclipse-omr#6486
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
These tests are disabled because core files cannot be generated on Linux in the Azure pipeline. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
jenkins build all |
|
@janvrany Can you provide feedback on these changes since @0xdaryl Requesting your feedback as well. In the current state, |
|
@babsingh : LGTM. Thanks! It actually seems to me that |
|
This PR needs to be merged. It is preventing cgroup v2 PRs from being tested:
Cgroup v2 support is targeted for OpenJ9's 0.33 release. D-cut is end of May 22. More PRs for cgroup v2 support will follow. So, we should avoid cgroup v2 PRs from piling up. |
|
Jenkins build zos |
Remove the
--gtest_filter=${porttest_filter}option for porttestWhen
${porttest_filter}is an empty string, no tests fromporttestarerun.
${porttest_filter}is never set in OMR so it will always be anempty string. Also,
--gtest_filter=${porttest_filter}conflicts withthe
GTEST_FILTERenvironment variable used byomrbuild.groovy. To avoidthe conflict and correctly run
porttest, the--gtest_filter=${porttest_filter}option is removed.
porttestshould consistently rely upon theGTEST_FILTERenvironment variable.
Changed
--gtest_filter="Cuda*"to--gtest_filter=*Cuda*. 0 tests are run.This allows
cuda_porttestto work correctly.Disable
*_create_dump_*tests for the "x86-64 Linux" job in AzureThese tests are disabled because core files cannot be generated on Linux
in the Azure pipeline.
Fixes: #6486
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com