Skip to content

Adopt -XX:+UseCompressedOops & -XX:-UseCompressedOops command options - #13681

Merged
gacholio merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:nocpressedop
Oct 13, 2021
Merged

gacholio merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:nocpressedop

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Oct 12, 2021 •

Copy link
Copy Markdown
Member

-XX:+UseCompressedOops & -XX:-UseCompressedOops command line options are taken into consideration for switching to compressedrefs/nocompressedrefs modes;
Added defines VMOPT_XXUSECOMPRESSEDOOPS & VMOPT_XXNOUSECOMPRESSEDOOPS.

issue #13561

This PR has been manually verified, automated test is to be added via #13660.

Signed-off-by: Jason Feng fengj@ca.ibm.com

@pshipton

Copy link
Copy Markdown
Member

if there are multiple conflicted options in the command line or environment variables, the behaviour is not defined

We use the right most option wins rule, please fix the code to do that.

@gacholio

Copy link
Copy Markdown
Contributor

It's hard to read the redirector changes as most of them seem unnecessary. Did anything real change there (the answer should be no)?

@JasonFengJ9

Copy link
Copy Markdown
Member Author

It's hard to read the redirector changes as most of them seem unnecessary. Did anything real change there (the answer should be no)?

No real changes, since this PR introduces VMOPT_XXUSECOMPRESSEDOOPS & VMOPT_XXNOUSECOMPRESSEDOOPS, it seems consistent to use the defines to replace those hard-code strings -XX:+UseCompressedOops -XX:+UseCompressedOops along with -Xcompressedrefs & -Xnocompressedrefs.

@JasonFengJ9

Copy link
Copy Markdown
Member Author

We use the right most option wins rule, please fix the code to do that.

Fixed.

Comment thread runtime/vm/jvminit.c Resolved
-XX:+UseCompressedOops & -XX:-UseCompressedOops command line options are
taken into consideration for switching to
compressedrefs/nocompressedrefs modes;
Added defines VMOPT_XXUSECOMPRESSEDOOPS & VMOPT_XXNOUSECOMPRESSEDOOPS.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@pshipton

Copy link
Copy Markdown
Member

jenkins test sanity win jdk8

@pshipton

Copy link
Copy Markdown
Member

@gacholio any further comments? Otherwise pls merge.
Jason, after it's merged we need a PR for the 0.29 branch.

@JasonFengJ9

Copy link
Copy Markdown
Member Author

after it's merged we need a PR for the 0.29 branch.

Created #13691, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants