Skip to content

Allow inline allocation for value types - #13889

Merged
0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:allow-valuetype-inlining-allocation
Nov 19, 2021
Merged

0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:allow-valuetype-inlining-allocation

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

Allow inline allocation for value types

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@a7ehuo a7ehuo added comp:jit project:valhalla Used to track Project Valhalla related work labels Nov 9, 2021
@a7ehuo
a7ehuo requested review from 0xdaryl, hzongaro and mpirvu November 9, 2021 15:45

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good from the point of view of VMJ9.cpp VMJ9Server.cpp files

@hzongaro hzongaro left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good so far. Were you planning to make the required changes for other platforms in this pull request as well, or will that be handled in follow up pull requests?

@a7ehuo

a7ehuo commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

Were you planning to make the required changes for other platforms in this pull request as well, or will that be handled in follow up pull requests?

The changes for other platforms are planned to be in a different commit. One reason is that I'm not sure if we could run valhalla functional Jekins test on other platforms yet.

@hzongaro hzongaro added the perf label Nov 10, 2021
@a7ehuo
a7ehuo force-pushed the allow-valuetype-inlining-allocation branch from add0746 to b796c85 Compare November 10, 2021 19:20
@a7ehuo

a7ehuo commented Nov 10, 2021 •

Copy link
Copy Markdown
Contributor Author

I'm going through test failures in Jenkins personal build. I'll remove WIP after I rule out all the failures.

@a7ehuo

a7ehuo commented Nov 11, 2021

Copy link
Copy Markdown
Contributor Author

While making the same change for other platforms, I found the code is repetitive and not platform specific from what I can see. Instead of adding the logic to the platform specific TreeEvaluator, I'm thinking of creating a new method bool J9::TreeEvaluator::inlineAllocateValueType(TR::Node *node, TR::CodeGenerator * cg) in codegen/J9TreeEvaluator.cpp. And all the platform specific TreeEvaluator such as J9::X86::TreeEvaluator::newEvaluator can call it. @hzongaro @0xdaryl Wondering if there is any concern over this proposed change?

@a7ehuo
a7ehuo force-pushed the allow-valuetype-inlining-allocation branch 2 times, most recently from 1ac3590 to 7388b99 Compare November 11, 2021 22:57
@a7ehuo

a7ehuo commented Nov 11, 2021 •

Copy link
Copy Markdown
Contributor Author

The proposed change is made in 7388b99 (Updated: 6a9ab1c). Ready for review. Thanks!

@a7ehuo
a7ehuo force-pushed the allow-valuetype-inlining-allocation branch from 7388b99 to 6a9ab1c Compare November 13, 2021 16:32
@a7ehuo a7ehuo changed the title WIP: Allow inline allocation for value types Allow inline allocation for value types Nov 15, 2021
@a7ehuo
a7ehuo marked this pull request as ready for review November 15, 2021 04:16

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My review comments are really minor.

Comment thread runtime/compiler/env/VMJ9.cpp Resolved
Add requireHelperCallValueTypeAllocation to check if inline allocation
is allowed when evaluating the "new" opcode and when value
type is enabled. If "new jitNewValue" is used to create a non
value type, or if "new jitNewObject" is used to create a value type,
InstantiationError exception needs to be thrown. Use helper call in
these cases.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the allow-valuetype-inlining-allocation branch from 6a9ab1c to a7ab6ed Compare November 15, 2021 16:28
@0xdaryl

0xdaryl commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended xlinuxval,plinuxval,zlinuxval,alinuxval jdknext

@a7ehuo

a7ehuo commented Nov 15, 2021

Copy link
Copy Markdown
Contributor Author

@0xdaryl Could we also run *linuxvalst as well? Thanks! *linuxval only tests value type related sanity tests.

@0xdaryl

0xdaryl commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Could we also run *linuxvalst as well?

Yes. I was staging the PR builds so as to not overwhelm the infrastructure.

@a7ehuo

a7ehuo commented Nov 15, 2021

Copy link
Copy Markdown
Contributor Author

aarch64 build failed due to a known issue with the master branch #13916.

I'm looking at the test failure from openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla test.

@0xdaryl

0xdaryl commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst,plinuxvalst,zlinuxvalst,alinuxvalst jdknext

@0xdaryl

0xdaryl commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst jdknext

@a7ehuo

a7ehuo commented Nov 16, 2021 •

Copy link
Copy Markdown
Contributor Author

The crash [1] from openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla happened in cmdLineTester_flattenedvaluetypeddrtests_0. I can't reproduce it locally so far. The backtrace doesn't show any symbol [2]. Also tried to run the failed command !j9object 0x00000000FFE387B8 on the generated core from the test. No crash [3].

  • Ran the test with the master branch in Grinder 100x: all fail. Looks like the core file failed to be generated [4]. Likely it's an infrastructure issue.
  • Ran the test with this PR change in Grinder 50x: all fail. same reason as the master branch [4].

[1]

[2021-11-15T18:40:54.982Z] Testing: Run !j9object 0x00000000FFE387B8 to display container array contents
[2021-11-15T18:40:54.982Z] Test start time: 2021/11/15 13:40:53 Eastern Standard Time
[2021-11-15T18:40:54.982Z] Running command: /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/openjdkbinary/j2sdk-image/bin/jdmpview -core /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.134035.16150.0001.dmp
[2021-11-15T18:40:54.982Z] Time spent starting: 4 milliseconds
[2021-11-15T18:41:23.993Z] Time spent executing: 29183 milliseconds
[2021-11-15T18:41:23.993Z] Test result: FAILED
[2021-11-15T18:41:23.993Z]  [OUT] DTFJView version 4.29.5, using DTFJ version 1.12.29003
[2021-11-15T18:41:23.993Z]  [OUT] Loading image from DTFJ...
[2021-11-15T18:41:23.993Z]  [OUT] 
[2021-11-15T18:41:23.993Z]  [ERR] Unhandled exception
[2021-11-15T18:41:23.993Z]  [ERR] Type=Segmentation error vmState=0x00000000
[2021-11-15T18:41:23.993Z]  [ERR] J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000080
[2021-11-15T18:41:23.993Z]  [ERR] Handler1=00007FEA900D3100 Handler2=00007FEA8BD9CBA0 InaccessibleAddress=0000000000000000
[2021-11-15T18:41:23.993Z]  [ERR] RDI=00007FEA6760C7D3 RSI=00007FEA6760C7D8 RAX=6020000000000001 RBX=00000000FFA4DC68
[2021-11-15T18:41:23.993Z]  [ERR] RCX=00000000000AFB00 RDX=00007FEA6760C7D8 R8=00000000FFA4DD88 R9=0000000000000001
[2021-11-15T18:41:23.993Z]  [ERR] R10=00000000FFA4DD48 R11=0000000000000001 R12=0000000000000000 R13=00000000FFA4DCE0
[2021-11-15T18:41:23.993Z]  [ERR] R14=0000000085D42E98 R15=00000000FFA4DC68
[2021-11-15T18:41:23.993Z]  [ERR] RIP=00007FEA83FE22D8 GS=0000 FS=0000 RSP=000000000010CA50
[2021-11-15T18:41:23.993Z]  [ERR] EFlags=0000000000010213 CS=0033 RBP=0000000000016F00 ERR=0000000000000000
[2021-11-15T18:41:23.993Z]  [ERR] TRAPNO=000000000000000D OLDMASK=0000000000000000 CR2=0000000000000000
[2021-11-15T18:41:23.993Z]  [ERR] xmm0 0000000000000005 (f: 5.000000, d: 2.470328e-323)
[2021-11-15T18:41:23.993Z]  [ERR] xmm1 63265f4d440c413b (f: 1141653760.000000, d: 4.221606e+169)
[2021-11-15T18:41:23.993Z]  [ERR] xmm2 000e1781000e1781 (f: 923521.000000, d: 1.959708e-308)
[2021-11-15T18:41:23.993Z]  [ERR] xmm3 00000000395d3e99 (f: 962412160.000000, d: 4.754948e-315)
[2021-11-15T18:41:23.993Z]  [ERR] xmm4 00000000bdf6d481 (f: 3187070208.000000, d: 1.574622e-314)
[2021-11-15T18:41:23.993Z]  [ERR] xmm5 100002003950f4bf (f: 961606848.000000, d: 1.288859e-231)
[2021-11-15T18:41:23.993Z]  [ERR] xmm6 00000000be6648e7 (f: 3194374400.000000, d: 1.578231e-314)
[2021-11-15T18:41:23.993Z]  [ERR] xmm7 726464396a2f6d62 (f: 1781493120.000000, d: 1.087767e+243)
[2021-11-15T18:41:23.993Z]  [ERR] xmm8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-15T18:41:23.993Z]  [ERR] xmm9 507373616c43394a (f: 1816344960.000000, d: 3.603580e+79)
[2021-11-15T18:41:23.993Z]  [ERR] xmm10 5d0e8c33b0c46118 (f: 2965659904.000000, d: 1.818888e+140)
[2021-11-15T18:41:23.993Z]  [ERR] xmm11 ffffffffffffffff (f: 4294967296.000000, d: -nan)
[2021-11-15T18:41:23.993Z]  [ERR] xmm12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-15T18:41:23.993Z]  [ERR] xmm13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-15T18:41:23.993Z]  [ERR] xmm14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-15T18:41:23.993Z]  [ERR] xmm15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-15T18:41:23.993Z]  [ERR] Module=/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/openjdkbinary/j2sdk-image/lib/default/libj9jit29.so
[2021-11-15T18:41:23.993Z]  [ERR] Module_base_address=00007FEA83B33000
[2021-11-15T18:41:23.993Z]  [ERR] Target=2_90_20211115_22 (Linux 3.10.0-1160.25.1.el7.x86_64)
[2021-11-15T18:41:23.993Z]  [ERR] CPU=amd64 (4 logical CPUs) (0x1e8cf3000 RAM)
[2021-11-15T18:41:23.993Z]  [ERR] ----------- Stack Backtrace -----------
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD995B2 [libj9prt29.so+0x265b2])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD9D903 [libj9prt29.so+0x2a903])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD9962E [libj9prt29.so+0x2662e])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD99724 [libj9prt29.so+0x26724])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD9D903 [libj9prt29.so+0x2a903])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD9948B [libj9prt29.so+0x2648b])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA900D2C44 [libj9vm29.so+0x41c44])
[2021-11-15T18:41:23.993Z]  [ERR] (0x00007FEA8BD9D903 [libj9prt29.so+0x2a903])
[2021-11-15T18:41:23.994Z]  [ERR] (0x00007FEA900D2EB5 [libj9vm29.so+0x41eb5])
[2021-11-15T18:41:23.994Z]  [ERR] (0x00007FEA901DD375 [libj9vm29.so+0x14c375])
[2021-11-15T18:41:23.994Z]  [ERR] ---------------------------------------
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP039I Processing dump event "gpf", detail "" at 2021/11/15 13:40:58 - please wait.
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.134058.16251.0001.dmp' in response to an event
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.134058.16251.0001.dmp
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/javacore.20211115.134058.16251.0002.txt' in response to an event
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/javacore.20211115.134058.16251.0002.txt
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/Snap.20211115.134058.16251.0003.trc' in response to an event
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP010I Snap dump written to /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/Snap.20211115.134058.16251.0003.trc
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP032I JVM requested JIT dump using '/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/jitdump.20211115.134058.16251.0004.dmp' in response to an event
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP051I JIT dump occurred in 'main' thread 0x0000000000016F00
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP053I JIT dump is recompiling java/lang/ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP010I JIT dump written to /home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linux_valhalla_Personal_testList_0/aqa-tests/TKG/output_16370016312460/cmdLineTester_flattenedvaluetypeddrtests_0/jitdump.20211115.134058.16251.0004.dmp
[2021-11-15T18:41:23.994Z]  [ERR] JVMDUMP013I Processed dump event "gpf", detail "".
[2021-11-15T18:41:23.994Z] >> Success condition was not found: [Output match: !J9IndexableObject 0x]
[2021-11-15T18:41:23.994Z] >> Required condition was not found: [Output match: [0] = !fj9object 0x]
[2021-11-15T18:41:23.994Z] >> Required condition was not found: [Output match: [2] = !fj9object 0x]
[2021-11-15T18:41:23.994Z] >> Required condition was not found: [Output match: [3] = !fj9object 0x]
[2021-11-15T18:41:23.994Z] >> Failure condition was not found: [Output match: Problem running command]

[2]

Cannot access memory at address 0x50000c7
Cannot access memory at address 0x50000bf
Core was generated by `/home/jenkins/workspace/Test_openjdkValhalla_j9_extended.functional_x86-64_linu'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fea9210eaa1 in ?? ()
(gdb) bt
#0  0x00007fea9210eaa1 in ?? ()
#1  0x00007fea8bd9be3d in ?? ()
#2  0xffffffffffffffff in ?? ()
#3  0xffffffffffffffff in ?? ()
#4  0x0000000000000000 in ?? ()

[3]

> !j9object 0x00000000FFE387B8
!J9IndexableObject 0x00000000FFE387B8 {
    struct J9Class* clazz = !j9arrayclass 0x2FF00   // [L
    Object flags = 0x00000000;
    U_32 size = 0x00000004;
	[0] = !fj9object 0xffe08e38 = !j9object 0xffe08e38
	[1] = !fj9object 0xffe0a070 = !j9object 0xffe0a070
	[2] = !fj9object 0xffe386a8 = !j9object 0xffe386a8
	[3] = !fj9object 0xffe35c90 = !j9object 0xffe35c90
}

[4]

Testing: Create core file
Test start time: 2021/11/15 13:24:54 Pacific Standard Time
Running command: "/home/jenkins/workspace/Grinder_testList_0/openjdkbinary/j2sdk-image/bin/java"   -Xmx24m -Xint -XX:ValueTypeFlatteningThreshold=999999 -XX:+EnableArrayFlattening -Xverify:none --add-opens java.base/jdk.internal.misc=ALL-UNNAMED -cp /home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/../../jvmtest/TKG/lib/asm-all.jar:/home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/../../jvmtest/TKG/lib/jcommander.jar:/home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/../../jvmtest/TKG/lib/testng.jar:/home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/../../jvmtest/functional/Valhalla/ValhallaTests.jar org.openj9.test.lworld.DDRValueTypeTest
Time spent starting: 8 milliseconds
Time spent executing: 7575 milliseconds
Test result: FAILED
 [ERR] JVMJ9VM193W Since Java 13 -Xverify:none and -noverify were deprecated for removal and may not be accepted options in the future.
 [ERR] JVMDUMP034I User requested System dump using '/home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/output_16370114927865/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.132454.28826.0001.dmp' through com.ibm.jvm.Dump.SystemDump
 [ERR] JVMPORT030W /proc/sys/kernel/core_pattern setting "|/usr/share/apport/apport %p %s %c %d %P %E" specifies that the core dump is to be piped to an external program.  Attempting to rename either core or core.28843.
 [ERR] 
 [ERR] JVMDUMP012E Error in System dump: The core file created by child process with pid = 28843 was not found. Expected to find core file with name "/home/jenkins/workspace/Grinder_testList_0/aqa-tests/TKG/output_16370114927865/cmdLineTester_flattenedvaluetypeddrtests_0/core"
>> Success condition was not found: [Output match: System dump written]
>> Required condition was not found: [Output match: System dump written to ]
>> Failure condition was not found: [Output match: Exception caught!]

@0xdaryl

0xdaryl commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst,plinuxvalst,zlinuxvalst,alinuxvalst jdknext

@a7ehuo

a7ehuo commented Nov 16, 2021 •

Copy link
Copy Markdown
Contributor Author

I reproduced the crash in cmdLineTester_flattenedvaluetypeddrtests_0 with the master branch.
FR: 3/153. I will create an issue to track it. [Update: tracked in #13932]

openjdk version "18-internal" 2022-03-15
OpenJDK Runtime Environment (build 18-internal+0-adhoc.root.openj9-openjdk-jdk)
Eclipse OpenJ9 VM (build master-bfcacfa62, JRE 18 Linux amd64-64-Bit Compressed References 20211115_000000 (JIT enabled, AOT enabled)
OpenJ9   - c4bbd378d
OMR      - dd087489c
JCL      - 6b0732d47e2 based on jdk-18+22)
Testing: Run !j9object 0xffe32800 to show the fields of the reference object
Test start time: 2021/11/15 22:58:04 Pacific Standard Time
Running command: /root/home/ahuo/src/openj9-openjdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/jdmpview -core /root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.225747.4032.0001.dmp
Time spent starting: 5 milliseconds
Time spent executing: 8995 milliseconds
Test result: FAILED
 [OUT] DTFJView version 4.29.5, using DTFJ version 1.12.29003
 [OUT] Loading image from DTFJ...
 [OUT] 
 [ERR] Unhandled exception
 [ERR] Type=Segmentation error vmState=0x00000000
 [ERR] J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000080
 [ERR] Handler1=00007FB2F3C29D00 Handler2=00007FB2F31DD1D0 InaccessibleAddress=0000000000000000
 [ERR] RDI=00007FB2D4F7C393 RSI=00007FB2D4F7C398 RAX=9020000000000001 RBX=00000000FFD97208
 [ERR] RCX=00000000000AFB00 RDX=00007FB2D4F7C398 R8=00000000FFD97220 R9=00000000FFD97178
 [ERR] R10=0000000000000000 R11=00000000FFD97178 R12=000000000000000A R13=0000000000251D00
 [ERR] R14=000000000000000A R15=00000000FFD97220
 [ERR] RIP=00007FB2F148D598 GS=0000 FS=0000 RSP=000000000010CC60
 [ERR] EFlags=0000000000010213 CS=0033 RBP=0000000000016F00 ERR=0000000000000000
 [ERR] TRAPNO=000000000000000D OLDMASK=0000000000000000 CR2=0000000000000000
 [ERR] xmm0 0000000000000005 (f: 5.000000, d: 2.470328e-323)
 [ERR] xmm1 0000000000000073 (f: 115.000000, d: 5.681755e-322)
 [ERR] xmm2 000e1781000e1781 (f: 923521.000000, d: 1.959708e-308)
 [ERR] xmm3 bfdffef1e8ca7635 (f: 3905582592.000000, d: -4.999356e-01)
 [ERR] xmm4 bfba4e76ce8c0e5e (f: 3465285120.000000, d: -1.027598e-01)
 [ERR] xmm5 ffffffffffffffff (f: 4294967296.000000, d: -nan)
 [ERR] xmm6 ffffffffffffffff (f: 4294967296.000000, d: -nan)
 [ERR] xmm7 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm8 070d190026b600b0 (f: 649461952.000000, d: 1.050539e-274)
 [ERR] xmm9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] xmm15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] Module=/root/home/ahuo/src/openj9-openjdk-jdk/build/linux-x86_64-server-release/images/jdk/lib/default/libj9jit29.so
 [ERR] Module_base_address=00007FB2F0FE7000
 [ERR] Target=2_90_20211115_000000 (Linux 4.15.0-161-generic)
 [ERR] CPU=amd64 (4 logical CPUs) (0x1f2814000 RAM)
 [ERR] ----------- Stack Backtrace -----------
 [ERR] (0x00007FB2F31D9BE2 [libj9prt29.so+0x24be2])
 [ERR] (0x00007FB2F31DDF33 [libj9prt29.so+0x28f33])
 [ERR] (0x00007FB2F31D9C5E [libj9prt29.so+0x24c5e])
 [ERR] (0x00007FB2F31D9D54 [libj9prt29.so+0x24d54])
 [ERR] (0x00007FB2F31DDF33 [libj9prt29.so+0x28f33])
 [ERR] (0x00007FB2F31D9ABB [libj9prt29.so+0x24abb])
 [ERR] (0x00007FB2F3C29844 [libj9vm29.so+0x41844])
 [ERR] (0x00007FB2F31DDF33 [libj9prt29.so+0x28f33])
 [ERR] (0x00007FB2F3C29AB5 [libj9vm29.so+0x41ab5])
 [ERR] (0x00007FB2F3D33F65 [libj9vm29.so+0x14bf65])
 [ERR] ---------------------------------------
 [ERR] JVMDUMP039I Processing dump event "gpf", detail "" at 2021/11/15 22:58:08 - please wait.
 [ERR] JVMDUMP032I JVM requested System dump using '/root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.225808.4133.0001.dmp' in response to an event
 [ERR] JVMDUMP010I System dump written to /root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/core.20211115.225808.4133.0001.dmp
 [ERR] JVMDUMP032I JVM requested Java dump using '/root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/javacore.20211115.225808.4133.0002.txt' in response to an event
 [ERR] JVMDUMP010I Java dump written to /root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/javacore.20211115.225808.4133.0002.txt
 [ERR] JVMDUMP032I JVM requested Snap dump using '/root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/Snap.20211115.225808.4133.0003.trc' in response to an event
 [ERR] JVMDUMP010I Snap dump written to /root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/Snap.20211115.225808.4133.0003.trc
 [ERR] JVMDUMP032I JVM requested JIT dump using '/root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/jitdump.20211115.225808.4133.0004.dmp' in response to an event
 [ERR] JVMDUMP051I JIT dump occurred in 'main' thread 0x0000000000016F00
 [ERR] JVMDUMP053I JIT dump is recompiling java/lang/ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;
 [ERR] JVMDUMP010I JIT dump written to /root/home/ahuo/src/openj9-openjdk-jdk/openj9/test/TKG/output_16370458654367/cmdLineTester_flattenedvaluetypeddrtests_0/jitdump.20211115.225808.4133.0004.dmp
 [ERR] JVMDUMP013I Processed dump event "gpf", detail "".
>> Success condition was not found: [Output match: tri (offset = 0) (Triangle2D)]
>> Success condition was not found: [Output match: line (offset = 56) (FlattenedLine2D)]
>> Success condition was not found: [Output match: i (offset = 72) (ValueInt)]
>> Failure condition was not found: [Output match: Problem running command]

@a7ehuo

a7ehuo commented Nov 16, 2021

Copy link
Copy Markdown
Contributor Author

sanity.functional_x86-64_linux_vt_standard_Personal failed due to a crash in cmdLineTester_callsitedbgddrext_openj9_0. I'm looking at if it'd be related to this change

@a7ehuo

a7ehuo commented Nov 17, 2021 •

Copy link
Copy Markdown
Contributor Author

The crash in cmdLineTester_callsitedbgddrext_openj9_0(sanity.functional_x86-64_linux_vt_standard) looks similar to the crash in cmdLineTester_flattenedvaluetypeddrtests_0 (extended.functional_x86-64_linux_valhalla). Both crashes occur when running jdmpview commands on a core file. The core files generated from both crashes seem corrupted to me. The backtrace doesn't show any symbol and gdb doesn't load libj9jit29.debuginfo.

For cmdLineTester_callsitedbgddrext_openj9_0

# gdb -iex "set solib-search-path $PWD/jdk/lib:$PWD/jdk/lib/default:$PWD/jdk/lib/j9vm" jdk/bin/java core.20211116.101517.17391.0001.dmp
...
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from jdk/bin/java...Reading symbols from /root/home/ahuo/src/issues_triage/pr_x86_vt_standard_sanity_cmdLineTester_callsitedbgddrext_openj9_0/aqa-tests/TKG/output_16370753828412/cmdLineTester_callsitedbgddrext_openj9_0/jdk/bin/java.debuginfo...done.
done.

warning: core file may not match specified executable file.
[New LWP 17424]
Core was generated by `/home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_s'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f4860155aa1 in ?? ()
(gdb) bt
#0  0x00007f4860155aa1 in ?? ()
#1  0x00007f485de73e3d in ?? ()
#2  0xffffffffffffffff in ?? ()
#3  0xffffffffffffffff in ?? ()
#4  0x0000000000000000 in ?? ()
(gdb) info sharedlibrary
No shared libraries loaded at this time.

@a7ehuo

a7ehuo commented Nov 17, 2021 •

Copy link
Copy Markdown
Contributor Author

@0xdaryl Here is a summary of the issues occurred during the PR build test. It doesn't look to me they'd be related to this change.

@a7ehuo

a7ehuo commented Nov 18, 2021 •

Copy link
Copy Markdown
Contributor Author

I got the symbol from the two crashes from Test_openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla and Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard. They are the same crash that hits doubleRotate. Likely it's called when it rebalances AVL tree. Especially, the test cmdLineTester_callsitedbgddrext_openj9_0 from Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard doesn't test value types. The crash doesn't look related to this change.

(gdb) where 
#0  0x00007f4860155aa1 in ?? ()
#1  0x00007f485de73e3d in omrdump_create (portLibrary=0x7f485f1603a0 <j9portLibrary>, 
    filename=0x7f485f960fe0 <hashTableAdd+704> "/home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard_Personal_testList_1/aqa-tests/TKG/output_16370753828412/cmdLineTester_callsitedbgddrext_openj9_0/", 
    dumpType=<optimized out>, userData=<optimized out>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/omr/port/unix/omrosdump.c:188
#2  0x00007f485d3cc6c2 in doSystemDump (agent=0x7f48580281c0, 
    label=0x7f485f960fe0 <hashTableAdd+704> "/home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard_Personal_testList_1/aqa-tests/TKG/output_16370753828412/cmdLineTester_callsitedbgddrext_openj9_0/", 
    context=0x7f485f9614a0 <hashTableAdd+1920>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/rasdump/dmpagent.c:747
#3  0x00007f485d3c84b5 in protectedDumpFunction (portLibrary=portLibrary@entry=0x7f485f1603a0 <j9portLibrary>, 
    userData=userData@entry=0x7f485f960f40 <hashTableAdd+544>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/rasdump/dmpagent.c:2843
#4  0x00007f485de75903 in omrsig_protect (portLibrary=0x7f485f1603a0 <j9portLibrary>, 
    fn=0x7f485d3c84a0 <protectedDumpFunction>, fn_arg=0x7f485f960f40 <hashTableAdd+544>, 
    handler=0x7f485d3c84c0 <signalHandler>, handler_arg=0x0, flags=505, result=0x7f485f960f38 <hashTableAdd+536>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/omr/port/unix/omrsignal.c:425
#5  0x00007f485d3cbb2b in runDumpFunction (agent=<optimized out>, 
    label=0x7f485f960fe0 <hashTableAdd+704> "/home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard_Personal_testList_1/aqa-tests/TKG/output_16370753828412/cmdLineTester_callsitedbgddrext_openj9_0/", 
    context=<optimized out>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/rasdump/dmpagent.c:2821
#6  0x00007f485d3cbcbf in runDumpAgent (vm=vm@entry=0x7f48580119e0, agent=agent@entry=0x7f48580281c0, 
    context=context@entry=0x7f485f9614a0 <hashTableAdd+1920>, state=state@entry=0x7f485f961498 <hashTableAdd+1912>, 
    detail=detail@entry=0x7f485f961520 <hashTableAdd+2048> "", timeNow=timeNow@entry=1637075717296)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/rasdump/dmpagent.c:2751
#7  0x00007f485d3e463e in triggerDumpAgents (vm=0x7f48580119e0, self=0x16f00, eventFlags=8192, eventData=<optimized out>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/rasdump/trigger.c:1012
#8  0x00007f485e119ca2 in generateDiagnosticFiles (portLibrary=portLibrary@entry=0x7f485f1603a0 <j9portLibrary>, 
    userData=userData@entry=0x7f485f961a00 <hashTableRehash+48>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/vm/gphandle.c:1159
#9  0x00007f485de75903 in omrsig_protect (portLibrary=0x7f485f1603a0 <j9portLibrary>, 
    fn=0x7f485e119bc0 <generateDiagnosticFiles>, fn_arg=0x7f485f961a00 <hashTableRehash+48>, 
    handler=0x7f485e119280 <recursiveCrashHandler>, handler_arg=0x7f485f9619d0 <hashTableRehash>, flags=505, 
    result=0x7f485f9619c8 <hashTableRemove+408>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/omr/port/unix/omrsignal.c:425
#10 0x00007f485e119eb5 in vmSignalHandler (portLibrary=0x7f485f1603a0 <j9portLibrary>, gpType=24, gpInfo=<optimized out>, 
    userData=<optimized out>)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/vm/gphandle.c:833
#11 0x00007f485e224375 in swapStacksAndRunHandler ()
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/build/linux-x86_64-server-release/vm/runtime/vm/stackswap.s:144
#12 0x0000000000016f00 in ?? ()
#13 0x00007f485f962c20 in doubleRotate (tree=<optimized out>, walk=0x7f485f962c20 <doubleRotate+160>, direction=24, 
    heightChange=0x10c3c0)
    at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/omr/util/avl/avlsup.c:234
#14 0x00007f4835671a98 in ?? ()
#15 0x00007f4858318880 in ?? ()
#16 0x000000000000000c in ?? ()
#17 0x00000000ff8fa6b8 in ?? ()
#18 0x0000000000000001 in ?? ()
#19 0x00000000ff8fa678 in ?? ()
#20 0x0000000000000001 in ?? ()
#21 0x0000000000000000 in ?? ()
``

@0xdaryl 0xdaryl self-assigned this Nov 19, 2021
@0xdaryl

0xdaryl commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity all jdknext

None of the VT tests appear related to this PR. Running non-VT sanity tests.

@0xdaryl
0xdaryl merged commit 7561d93 into eclipse-openj9:master Nov 19, 2021
@a7ehuo
a7ehuo deleted the allow-valuetype-inlining-allocation branch January 12, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jit perf project:valhalla Used to track Project Valhalla related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants