Repository navigation
Allow inline allocation for value types - #13889
Conversation
mpirvu
left a comment
There was a problem hiding this comment.
Changes look good from the point of view of VMJ9.cpp VMJ9Server.cpp files
The changes for other platforms are planned to be in a different commit. One reason is that I'm not sure if we could run valhalla functional Jekins test on other platforms yet. |
add0746 to
b796c85
Compare
|
I'm going through test failures in Jenkins personal build. I'll remove |
|
While making the same change for other platforms, I found the code is repetitive and not platform specific from what I can see. Instead of adding the logic to the platform specific TreeEvaluator, I'm thinking of creating a new method |
1ac3590 to
7388b99
Compare
|
The proposed change is made in |
7388b99 to
6a9ab1c
Compare
hzongaro
left a comment
There was a problem hiding this comment.
Looks good. My review comments are really minor.
Add requireHelperCallValueTypeAllocation to check if inline allocation is allowed when evaluating the "new" opcode and when value type is enabled. If "new jitNewValue" is used to create a non value type, or if "new jitNewObject" is used to create a value type, InstantiationError exception needs to be thrown. Use helper call in these cases. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
6a9ab1c to
a7ab6ed
Compare
|
Jenkins test sanity,extended xlinuxval,plinuxval,zlinuxval,alinuxval jdknext |
|
@0xdaryl Could we also run |
Yes. I was staging the PR builds so as to not overwhelm the infrastructure. |
|
aarch64 build failed due to a known issue with the master branch #13916. I'm looking at the test failure from openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla test. |
|
Jenkins test sanity xlinuxvalst,plinuxvalst,zlinuxvalst,alinuxvalst jdknext |
|
Jenkins test sanity xlinuxvalst jdknext |
|
The crash [1] from openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla happened in
[1] [2] [3] [4] |
|
Jenkins test sanity xlinuxvalst,plinuxvalst,zlinuxvalst,alinuxvalst jdknext |
|
I reproduced the crash in |
|
sanity.functional_x86-64_linux_vt_standard_Personal failed due to a crash in |
|
The crash in For
|
|
@0xdaryl Here is a summary of the issues occurred during the PR build test. It doesn't look to me they'd be related to this change.
|
|
I got the symbol from the two crashes from Test_openjdkvalhalla_j9_extended.functional_x86-64_linux_valhalla and Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard. They are the same crash that hits |
|
Jenkins test sanity all jdknext None of the VT tests appear related to this PR. Running non-VT sanity tests. |
Allow inline allocation for value types
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com