Skip to content

Remove sigvec reference in CMakeLists.txt - #6958

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
FoxieFlakey:patch-2
Mar 20, 2024
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
FoxieFlakey:patch-2

Conversation

@FoxieFlakey

@FoxieFlakey FoxieFlakey commented Apr 20, 2023 •

Copy link
Copy Markdown
Contributor

This was overlooked in #972 which removed all instances of sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting the project, and congratulations on your first contribution! A project committer will shortly review your contribution. In the mean time, if you haven't had a chance please skim over the contribution guidelines which all pull requests must adhere to. If the ECA pull request check fails, have a look at the instructions for signing the ECA in the legal considerations section.

If you run into any problems our community will be happy to assist you in any way we can. There are a number of recommended ways to interact with the community. We encourage you to ask questions, or drop by to say hello.

@babsingh

Copy link
Copy Markdown
Contributor

@FluffyFoxUwU

eclipsefdn/eca Eclipse Contributor Agreement (ECA) check fails

You need to sign the ECA. Please see the following instructions: https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#legal-considerations.

Commit message guidelines

Instructions: https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines

  • The first line should be less than 70 characters
  • The body should be wrapped at 72 characters
  • Avoid using markdown in the commit message since it does not get processed: https://github.com/eclipse/omr/pull/6958/commits. It is fine to use it in the PR description.

@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

I'm not ready to give my real name in the Legal Name field yet. Is that mean I can't contribute until I give and sign it?

@babsingh

Copy link
Copy Markdown
Contributor

@0xdaryl Do you have guidance for the above ECA question #6958 (comment)?

@babsingh

Copy link
Copy Markdown
Contributor

@0xdaryl is on vacation. re #6958 (comment): @mstoodle Can @FluffyFoxUwU complete the ECA without providing a legal name?

@mstoodle

mstoodle commented Apr 20, 2023 •

Copy link
Copy Markdown
Contributor

Hi @FluffyFoxUwU Notwithstanding that this particular PR only removes code (which will make part of this answer sound pretty ironic), I think you'll need to provide your legal name to the Eclipse Foundation to sign the ECA since you're basically asserting that you have the legal right to contribute these code changes and there needs to be a real person doing that (in case, say, there is ever a legal dispute over the provenance of the code contribution).

I don't know whether your legal name becomes public knowledge as part of signing the ECA (I would be surprised, to be honest, but you would need to check that with the Eclipse Foundation), if that's your concern. As far as I know, the validation check just uses your GitHub id whoops email address so only the EF itself (I think, you need to verify) would have a record. I realize this probably isn't a fully satisfying answer, but I think it's the best we can do for you.

Regardless of whether you end up deciding to sign the ECA, thanks for coming to the project and for trying to contribute an improvement. We appreciate that you volunteered your own time to the project!

@mstoodle

Copy link
Copy Markdown
Contributor

Lemme see if the Eclipse Foundation allows an exception for "removals" which would at least let us accept this PR.

@mstoodle

mstoodle commented Apr 20, 2023 •

Copy link
Copy Markdown
Contributor

I sent a question to license@eclipse.org to ask if we can accept a code removal from an contributor who has not signed the ECA. If you want to follow up on the legal name requirement, you can also reach out to the same email address.

I'll report back when I get a response.

@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

Ok, thanks. I'll wait for your response.

@mstoodle

Copy link
Copy Markdown
Contributor

I heard back from the EF and we are allowed to override the requirement if we are convinced that no IP is being added to the project, and I think this contribution meets this bar.

I would like to see a committer approval including a statement that we've done all the relevant testing (@babsingh would you proceed with that, please?), then one of the leads (myself or @0xdaryl, if he's back, or even @charliegracie if he gets keen :) ) will merge this PR on that basis. Please @ mention the leads when this PR is ready to be merged.

@babsingh

Copy link
Copy Markdown
Contributor

@babsingh would you proceed with that, please?

Yes, and I will ping the leads once the PR is ready to be merged.

@babsingh

babsingh commented Apr 21, 2023 •

Copy link
Copy Markdown
Contributor

re #6958 (comment): @FluffyFoxUwU The commit message guidelines are still unsatisfied. The first line should be less than 70 chars. The subsequent lines (body) should be less than 72 chars. Please see the modified commit message below, which follows the guidelines. Also, the commit message and PR description should match.

Remove sigvec reference in CMakeLists.txt

This was overlooked in #972 which removed all instances of sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain

@FoxieFlakey
FoxieFlakey force-pushed the patch-2 branch 2 times, most recently from 469e890 to c91481b Compare April 22, 2023 00:15
@FoxieFlakey FoxieFlakey changed the title Removed sigvec reference in CMakeLists.txt Remove sigvec reference in CMakeLists.txt Apr 22, 2023
@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

re #6958 (comment): @babsingh Ok, I fixed the commit message and PR message. And do I do the reply correctly? because this repo atleast has different way replying from what I can observe.

@babsingh

Copy link
Copy Markdown
Contributor

@FluffyFoxUwU Yes, you replied correctly. Your code changes are good. Starting other testing:

jenkins build all

https://dev.azure.com/eclipse-omr/ea4519db-b27e-4d19-a971-f01491f803e3/_apis/build/builds/7410/logs/44

OSX failures are due to a known issue: #6516; so, they can be ignored.

@babsingh babsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstoodle @0xdaryl @charliegracie Testing looks good. No sigvec refs found in OMR or OpenJ9. So, it is safe to remove this code.

zOS PR build failed due to an infra issue. The code changes are disabled on zOS; so, we don't need a zOS PR build.

OSX failures are due to a known issue: #6516; so, they can be ignored.

@AdamBrousseau

Copy link
Copy Markdown
Contributor

jenkins build zos

@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

I have repushed to sign the commit. Please re-review the file changes @babsingh

@babsingh

Copy link
Copy Markdown
Contributor

#6958 (comment) contains the corrected version of the commit message. The commit title on the first line is still missing: Remove sigvec reference in CMakeLists.txt.

This was overlooked in eclipse-omr#972 which removed all instances of sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain
@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

re #6958 (comment): @babsingh Oops, sorry I accidentally missed the title.

@babsingh

Copy link
Copy Markdown
Contributor

OSX failure is #7181 (known and unrelated).

The previous testing looked good. I have restarted the PR builds for reconfirmation.

jenkins build all

@0xdaryl As per #6958 (comment), can you please merge this PR once the PR builds pass?

@babsingh

Copy link
Copy Markdown
Contributor

OSX PR build failed due to a known and unrelated issue: #7181.

@0xdaryl 0xdaryl self-assigned this Mar 20, 2024

@0xdaryl 0xdaryl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not add any new IP to the project, hence we can accept it without the author signing the ECA. Reviews have been signed off and no test issues are present.

@0xdaryl
0xdaryl merged commit 54b23e9 into eclipse-omr:master Mar 20, 2024
@FoxieFlakey

Copy link
Copy Markdown
Contributor Author

Thank you everyone for being nice and accepting my PR ^w^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants