Skip to content

Improve allocation explain API for canRemain - #152121

Merged
surya-estc merged 13 commits into
elastic:mainfrom
surya-estc:allocation/explain_can_remain_on_current_node
Jul 3, 2026
Merged

surya-estc merged 13 commits into
elastic:mainfrom
surya-estc:allocation/explain_can_remain_on_current_node

Conversation

@surya-estc

Copy link
Copy Markdown
Contributor

- For current node, if the canRemain decision is true and debug mode is
on, output the canRemain deciders
- Update unit tests
- Closes elastic#131603
@surya-estc
surya-estc requested a review from nicktindall June 30, 2026 22:04
@surya-estc surya-estc added the :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. label Jul 1, 2026
@surya-estc
surya-estc marked this pull request as ready for review July 1, 2026 21:54
@surya-estc
surya-estc requested a review from nicktindall July 1, 2026 21:54
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Jul 1, 2026
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @surya-estc, I've created a changelog YAML for you.

@github-actions

github-actions Bot commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@nicktindall nicktindall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a query if we can use an existing utility to convert to JSON

@surya-estc
surya-estc enabled auto-merge (squash) July 2, 2026 22:18
@surya-estc
surya-estc merged commit 1b7f607 into elastic:main Jul 3, 2026
36 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 3, 2026
…uisition

* upstream/main: (65 commits)
  Use forceEvictEntries for all forceEvict methods (elastic#152846)
  [ESQL] Normalize local StorageObject path for stats reconcile (elastic#152837)
  Report vectordb_document usage in _xpack/usage (elastic#152780)
  Mute org.elasticsearch.common.lucene.LuceneTests testSearchWithoutBulkScorer elastic#152898
  Make DiskBBQ CentroidSupplier generic in the indexing method (elastic#152863)
  AGGS: Prevent OOM in test (elastic#152690)
  [CI] Fix bc upgrade disk size (elastic#152895)
  Mute org.elasticsearch.xpack.transform.integration.TransformIT testStopWaitForCheckpoint elastic#149663
  Always report script queries as maximum cost (elastic#152856)
  test(tsdb): cover `ES95` ordinal doc values (elastic#152802)
  Skip semantic_field source yaml tests in release (elastic#152852)
  Mute org.elasticsearch.xpack.esql.action.NdJsonScalarObjectConflictIT testSkipRowPolicyNullFillsAndWarnsClient elastic#152891
  [ESQL] Async STOP / cancel / DELETE contract for EXTERNAL queries (elastic#152585)
  Unmute rolling upgrade tests (elastic#152715)
  [ESQL] Fix ExternalSourceExec BWC serialization test types (elastic#152836)
  Add AllocateReshardSplitTargetPrimaryCommand (elastic#152806)
  [ESQL] Reconcile temporal stat units in cross-file merge (elastic#152859)
  ES|QL: error on `match` options w/ runtime field (elastic#152597)
  Improve allocation explain API for canRemain decisions (elastic#152121)
  [Inference API] Remove fallbackRegion from RegionPolicy (elastic#152798)
  ...
burqen pushed a commit to burqen/elasticsearch that referenced this pull request Jul 7, 2026
* Improve allocation explain API for canRemain decisions

- For current node, if the canRemain decision is true and debug mode is
on, output the canRemain deciders
- Update unit tests
- Closes elastic#131603

* Update ITs to assert can_remain_decisions

* Update docs/changelog/152121.yaml

* Simplify helper code in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed Meta label for distributed team. v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allocation explain should explain current node allocation decisions

3 participants