Repository navigation
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @costin, I've created a changelog YAML for you. |
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
| Path file = createTempFile(); | ||
| LocalStorageObject obj = new LocalStorageObject(file); | ||
| assertEquals(StoragePath.fileUri(file), obj.path().toString()); | ||
| assertEquals(StoragePath.of(StoragePath.fileUri(file)), obj.path()); |
There was a problem hiding this comment.
On POSIX, the old "file://" + toAbsolutePath() and the new fileUri(...) produce byte-identical strings (no backslashes to normalize), so this assertion holds whether or not the fix is applied. Since it compares against fileUri() itself rather than a literal expected value, could this pass on non-Windows CI even without the fix?
There was a problem hiding this comment.
Now asserts no-backslash + file:/// shape; added test-windows lane.
There was a problem hiding this comment.
Were these confirmed to have failed on Windows specifically? The fix is a Windows-only backslash normalization (identical output on POSIX before/after), but this PR isn't labeled test-windows, so the Windows CI lane won't exercise it here. If the original mutes were from Linux CI failures, would unmuting still be safe?
There was a problem hiding this comment.
Windows-lane failures; added test-windows label to exercise here.
| // SchemaCacheKey canonicalPath, so ExternalSourceCacheService.reconcileSourceStats silently | ||
| // dropped every captured contribution and warm queries re-scanned. On POSIX both forms | ||
| // already coincide, so this is a no-op there. | ||
| this.storagePath = StoragePath.of(StoragePath.fileUri(filePath)); |
There was a problem hiding this comment.
This duplicates LocalStorageProvider.toStoragePath's StoragePath.of(StoragePath.fileUri(...)) one-liner. Since divergence between these two producers is exactly what caused this bug, would a shared factory (e.g. StoragePath.ofLocalPath(Path)) be worth extracting so they can't drift apart again?
There was a problem hiding this comment.
Extracted shared StoragePath.ofLocalPath; both producers now use it.
|
BTW, same as before, you might want to include |
LocalStorageObject built its StoragePath via "file://" + toAbsolutePath(), which keeps backslashes on Windows (file://C:\dir\file), while every other producer uses StoragePath.fileUri (file:///C:/dir/file). The stats-capture key (object.path()) therefore never matched the planning-side SchemaCacheKey canonicalPath on Windows, so reconcileSourceStats silently dropped every captured contribution and warm queries re-scanned instead of short-circuiting. Use fileUri in the constructor (no-op on POSIX) and add a cross-platform regression test. Unmutes the pushdown cold-then-warm suite.
dd4fae3 to
16c6e61
Compare
…uisition * upstream/main: (65 commits) Use forceEvictEntries for all forceEvict methods (elastic#152846) [ESQL] Normalize local StorageObject path for stats reconcile (elastic#152837) Report vectordb_document usage in _xpack/usage (elastic#152780) Mute org.elasticsearch.common.lucene.LuceneTests testSearchWithoutBulkScorer elastic#152898 Make DiskBBQ CentroidSupplier generic in the indexing method (elastic#152863) AGGS: Prevent OOM in test (elastic#152690) [CI] Fix bc upgrade disk size (elastic#152895) Mute org.elasticsearch.xpack.transform.integration.TransformIT testStopWaitForCheckpoint elastic#149663 Always report script queries as maximum cost (elastic#152856) test(tsdb): cover `ES95` ordinal doc values (elastic#152802) Skip semantic_field source yaml tests in release (elastic#152852) Mute org.elasticsearch.xpack.esql.action.NdJsonScalarObjectConflictIT testSkipRowPolicyNullFillsAndWarnsClient elastic#152891 [ESQL] Async STOP / cancel / DELETE contract for EXTERNAL queries (elastic#152585) Unmute rolling upgrade tests (elastic#152715) [ESQL] Fix ExternalSourceExec BWC serialization test types (elastic#152836) Add AllocateReshardSplitTargetPrimaryCommand (elastic#152806) [ESQL] Reconcile temporal stat units in cross-file merge (elastic#152859) ES|QL: error on `match` options w/ runtime field (elastic#152597) Improve allocation explain API for canRemain decisions (elastic#152121) [Inference API] Remove fallbackRegion from RegionPolicy (elastic#152798) ...
…c#152837) `LocalStorageObject` built its `StoragePath` via `"file://" + toAbsolutePath()`, keeping backslashes on Windows (`file://C:\dir\file`), while every other producer uses `StoragePath.fileUri` (`file:///C:/dir/file`). So the stats-capture key (`object.path()`) never matched the planning-side `SchemaCacheKey` canonical path on Windows, and `reconcileSourceStats` silently dropped every contribution — warm queries re-scanned instead of short-circuiting. Use `fileUri` in the constructor (no-op on POSIX), add a cross-platform regression test. Unmutes the pushdown cold-then-warm suite.
LocalStorageObjectbuilt itsStoragePathvia"file://" + toAbsolutePath(), keeping backslashes on Windows (file://C:\dir\file), while every other producer usesStoragePath.fileUri(file:///C:/dir/file). So the stats-capture key (object.path()) never matched the planning-sideSchemaCacheKeycanonical path on Windows, andreconcileSourceStatssilently dropped every contribution — warm queries re-scanned instead of short-circuiting. UsefileUriin the constructor (no-op on POSIX), add a cross-platform regression test. Unmutes the pushdown cold-then-warm suite.