Repository navigation
feat(web): undo delete - #18729
Merged
Merged
feat(web): undo delete#18729
Conversation
- Update English translation
alextran1502
approved these changes
Jun 2, 2025
alextran1502
enabled auto-merge (squash)
June 2, 2025 14:52
Make onUndoDelete optional in Props interface
auto-merge was automatically disabled
June 2, 2025 15:24
Head branch was pushed to by a user without write access
…bled. - Enforce lint requirement for no-negated-condition
xCJPECKOVERx
commented
Jun 4, 2025
| button: { text: $t('undo'), onClick: () => undoDeleteAssets(onUndoDelete, assets) }, | ||
| timeout: 5000, | ||
| }), | ||
| ...(onUndoDelete && |
Collaborator
Author
There was a problem hiding this comment.
Prettier tends to have some weird opinions on formatting lol
Member
There was a problem hiding this comment.
You can run npm run format:fix in the web directory for fix everything
Collaborator
Author
There was a problem hiding this comment.
Will do in the future. Didn't here since I didn't expect it to have an issue and make things arguably less readable.
I'll fix up the lint issue then I think we'll be good
alextran1502
approved these changes
Jun 4, 2025
alextran1502
enabled auto-merge (squash)
June 4, 2025 15:45
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
* feat(web): Undo asset delete * - lints and checks - Update English translation * Update delete-assets.svelte Make onUndoDelete optional in Props interface * - Ensure undo button not available on permanent delete, or trash disabled. - Enforce lint requirement for no-negated-condition * Fix formatting * fix: lint --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds undo button to the Assets Trashed notification.
Addresses #9571
How Has This Been Tested?
Tested on web using both trash menu button and delete key shortcut. Applies to most photos pages except Archive, Trash, and Locked. Undo option does not appear on those pages.
The notification timeout is extended to 5s when the undo button is present.
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)