Skip to content

Upgrade Normaliz version to 3.6.3 and PyNormaliz to 1.19 #25090

Closed

Description

@mkoeppe

Upstream:

Normaliz:

(cd upstream && wget 'https://github.com/Normaliz/Normaliz/releases/download/v3.6.3/normaliz-3.6.3.tar.gz')

PyNormaliz 1.19:

(cd upstream && wget 'https://files.pythonhosted.org/packages/7f/e9/3c15d1fc8ebba8a2ed17fc0f209804dc1240166a686d2f592305efc9d25e/PyNormaliz-1.19.tar.gz') 

Some more helper functions were included to facilitate the interfacing.

Depends on #22984

CC: @jplab @sebasguts @mo271 @videlec @w-bruns @mkoeppe @tscrim

Component: packages: optional

Keywords: IMA-PolyGeom

Author: Matthias Koeppe, Jean-Philippe Labbé

Branch/Commit: 36d5473

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25090

Activity

  1. mkoeppe commented on Apr 3, 2018

    @mkoeppe
    ContributorAuthor
  2. mkoeppe commented on Apr 3, 2018

    @mkoeppe
    ContributorAuthor

    Commit: eaedcc2

  3. mkoeppe commented on Apr 3, 2018

    @mkoeppe
    ContributorAuthor

    Last 10 new commits:

    737552dUpdating patch with upstream fix for wrong number of lattice points.
    530302dMerge branch 'u/tscrim/upgrade_noramliz_pynormaliz-22984' of git://trac.sagemath.org/sage into u/tscrim/upgrade_noramliz_pynormaliz-22984
    57d40b0Upgrade Normaliz to 3.5.2.
    6ba442dAdding tests from [comment:24](#comment%3A24),25 of #22984.
    183087aUpgrade PyNormaliz to 1.12
    7f47ec9Adapted the polyhedron docstring
    117e428Upgrade normaliz to 3.5.3
    7057ef4Merge branch to get docstring adaptation
    b6ae686Merge branch 'develop' of git://trac.sagemath.org/sage into t/25090/pynormaliz2
    eaedcc2Update PyNormaliz to 1.14
  4. jplab commented on Apr 3, 2018

    @jplab
    Contributor

    Changed commit from eaedcc2 to 4dbdc7d

  5. jplab commented on Apr 3, 2018

    @jplab
    Contributor
  6. jplab commented on Apr 3, 2018

    @jplab
    Contributor

    New commits:

    4dbdc7dUpdated the Cone calls format
  7. mkoeppe commented on Apr 4, 2018

    @mkoeppe
    ContributorAuthor
  8. jplab commented on Apr 4, 2018

    @jplab
  9. jplab commented on Apr 4, 2018

    @jplab
    Contributor
  10. jplab commented on Apr 4, 2018

    @jplab
    Contributor

    New commits:

    1dcef4c_init_from_normaliz_data: New, use it in _init_from_*representation
    fcd8101Updated pynormaliz to 1.15
  11. jplab commented on Apr 4, 2018

    @jplab
    Contributor

    Changed commit from 4dbdc7d to fcd8101

  12. mkoeppe commented on Apr 4, 2018

    @mkoeppe
    Author
  13. sagetrac-git commented on Apr 4, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    19d8539Polyhedron_normaliz: In verbose mode, write out normaliz format files
  14. sagetrac-git commented on Apr 4, 2018

    sagetrac-gitmannequin
    Mannequin

    Changed commit from fcd8101 to 19d8539

  15. sagetrac-git commented on Apr 4, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    4cfcd14_normaliz_format: Fix last change
  16. 71 remaining items

  17. tscrim commented on Sep 16, 2018

    @tscrim
    Collaborator
    comment:59

    Thank you. LGTM.

  18. mkoeppe commented on Sep 16, 2018

    @mkoeppe
    ContributorAuthor
    comment:60

    Thanks for reviewing!

  19. vbraun commented on Sep 16, 2018

    @vbraun
    Member
    comment:61
    sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py
    **********************************************************************
    File "src/sage/geometry/polyhedron/backend_normaliz.py", line 451, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
    Failed example:
        P._get_nmzcone_data()
    Exception raised:
        Traceback (most recent call last):
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
            self.compile_and_execute(example, compiler, test.globs)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
            exec(compiled, globs)
          File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[1]>", line 1, in <module>
            P._get_nmzcone_data()
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 464, in _get_nmzcone_data
            import PyNormaliz
        ImportError: No module named PyNormaliz
    **********************************************************************
    File "src/sage/geometry/polyhedron/backend_normaliz.py", line 456, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
    Failed example:
        C = Polyhedron(backend='normaliz',rays=[[1,2],[2,1]])
    Exception raised:
        Traceback (most recent call last):
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
            self.compile_and_execute(example, compiler, test.globs)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
            exec(compiled, globs)
          File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[2]>", line 1, in <module>
            C = Polyhedron(backend='normaliz',rays=[[Integer(1),Integer(2)],[Integer(2),Integer(1)]])
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/constructor.py", line 600, in Polyhedron
            return parent(Vrep, Hrep, convert=convert, verbose=verbose)
          File "sage/structure/parent.pyx", line 923, in sage.structure.parent.Parent.__call__ (build/cythonized/sage/structure/parent.c:9706)
            return mor._call_with_args(x, args, kwds)
          File "sage/structure/coerce_maps.pyx", line 164, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (build/cythonized/sage/structure/coerce_maps.c:5112)
            raise
          File "sage/structure/coerce_maps.pyx", line 159, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (build/cythonized/sage/structure/coerce_maps.c:5000)
            return C._element_constructor(x, *args, **kwds)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/parent.py", line 517, in _element_constructor_
            return self.element_class(self, Vrep, Hrep, **kwds)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 156, in __init__
            Polyhedron_base.__init__(self, parent, Vrep, Hrep, **kwds)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/base.py", line 124, in __init__
            self._init_from_Vrepresentation(vertices, rays, lines, **kwds)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 263, in _init_from_Vrepresentation
            self._init_from_normaliz_data(data, verbose=verbose)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 192, in _init_from_normaliz_data
            import PyNormaliz
        ImportError: No module named PyNormaliz
    **********************************************************************
    File "src/sage/geometry/polyhedron/backend_normaliz.py", line 457, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
    Failed example:
        C._get_nmzcone_data()
    Exception raised:
        Traceback (most recent call last):
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
            self.compile_and_execute(example, compiler, test.globs)
          File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
            exec(compiled, globs)
          File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[3]>", line 1, in <module>
            C._get_nmzcone_data()
        NameError: name 'C' is not defined
    **********************************************************************
    1 item had failures:
       3 of   5 in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
        [12 tests, 3 failures, 0.14 s]
    ----------------------------------------------------------------------
    sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py  # 3 doctests failed
    ----------------------------------------------------------------------
    
  20. sagetrac-git commented on Sep 16, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    36d5473src/sage/geometry/polyhedron/backend_normaliz.py: Add # optional - pynormaliz
  21. sagetrac-git commented on Sep 16, 2018

    sagetrac-gitmannequin
    Mannequin

    Changed commit from f3d11a3 to 36d5473

  22. tscrim commented on Sep 16, 2018

    @tscrim
    Collaborator
    comment:64

    Whoops, forgot to test on a machine that did not have (py)normaliz installed. Sorry Volker.

  23. vbraun commented on Sep 19, 2018

    @vbraun
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions