You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Upgrade Normaliz version to 3.6.3 and PyNormaliz to 1.19 #25090
sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py
**********************************************************************
File "src/sage/geometry/polyhedron/backend_normaliz.py", line 451, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
Failed example:
P._get_nmzcone_data()
Exception raised:
Traceback (most recent call last):
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[1]>", line 1, in <module>
P._get_nmzcone_data()
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 464, in _get_nmzcone_data
import PyNormaliz
ImportError: No module named PyNormaliz
**********************************************************************
File "src/sage/geometry/polyhedron/backend_normaliz.py", line 456, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
Failed example:
C = Polyhedron(backend='normaliz',rays=[[1,2],[2,1]])
Exception raised:
Traceback (most recent call last):
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[2]>", line 1, in <module>
C = Polyhedron(backend='normaliz',rays=[[Integer(1),Integer(2)],[Integer(2),Integer(1)]])
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/constructor.py", line 600, in Polyhedron
return parent(Vrep, Hrep, convert=convert, verbose=verbose)
File "sage/structure/parent.pyx", line 923, in sage.structure.parent.Parent.__call__ (build/cythonized/sage/structure/parent.c:9706)
return mor._call_with_args(x, args, kwds)
File "sage/structure/coerce_maps.pyx", line 164, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (build/cythonized/sage/structure/coerce_maps.c:5112)
raise
File "sage/structure/coerce_maps.pyx", line 159, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (build/cythonized/sage/structure/coerce_maps.c:5000)
return C._element_constructor(x, *args, **kwds)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/parent.py", line 517, in _element_constructor_
return self.element_class(self, Vrep, Hrep, **kwds)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 156, in __init__
Polyhedron_base.__init__(self, parent, Vrep, Hrep, **kwds)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/base.py", line 124, in __init__
self._init_from_Vrepresentation(vertices, rays, lines, **kwds)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 263, in _init_from_Vrepresentation
self._init_from_normaliz_data(data, verbose=verbose)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 192, in _init_from_normaliz_data
import PyNormaliz
ImportError: No module named PyNormaliz
**********************************************************************
File "src/sage/geometry/polyhedron/backend_normaliz.py", line 457, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
Failed example:
C._get_nmzcone_data()
Exception raised:
Traceback (most recent call last):
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 659, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1070, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data[3]>", line 1, in <module>
C._get_nmzcone_data()
NameError: name 'C' is not defined
**********************************************************************
1 item had failures:
3 of 5 in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._get_nmzcone_data
[12 tests, 3 failures, 0.14 s]
----------------------------------------------------------------------
sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py # 3 doctests failed
----------------------------------------------------------------------
Activity
mkoeppe commentedon Apr 3, 2018
Branch: u/mkoeppe/pynormaliz2
mkoeppe commentedon Apr 3, 2018
Commit:
eaedcc2mkoeppe commentedon Apr 3, 2018
Last 10 new commits:
737552dUpdating patch with upstream fix for wrong number of lattice points.530302dMerge branch 'u/tscrim/upgrade_noramliz_pynormaliz-22984' of git://trac.sagemath.org/sage into u/tscrim/upgrade_noramliz_pynormaliz-2298457d40b0Upgrade Normaliz to 3.5.2.6ba442dAdding tests from [comment:24](#comment%3A24),25 of #22984.183087aUpgrade PyNormaliz to 1.127f47ec9Adapted the polyhedron docstring117e428Upgrade normaliz to 3.5.37057ef4Merge branch to get docstring adaptationb6ae686Merge branch 'develop' of git://trac.sagemath.org/sage into t/25090/pynormaliz2eaedcc2Update PyNormaliz to 1.14jplab commentedon Apr 3, 2018
Changed commit from
eaedcc2to4dbdc7djplab commentedon Apr 3, 2018
Changed branch from u/mkoeppe/pynormaliz2 to u/jipilab/pynormaliz2
jplab commentedon Apr 3, 2018
New commits:
4dbdc7dUpdated the Cone calls formatmkoeppe commentedon Apr 4, 2018
Changed branch from u/jipilab/pynormaliz2 to u/mkoeppe/pynormaliz2
jplab commentedon Apr 4, 2018
jplab commentedon Apr 4, 2018
Changed branch from u/mkoeppe/pynormaliz2 to public/pynormaliz2
jplab commentedon Apr 4, 2018
New commits:
1dcef4c_init_from_normaliz_data: New, use it in _init_from_*representationfcd8101Updated pynormaliz to 1.15jplab commentedon Apr 4, 2018
Changed commit from
4dbdc7dtofcd8101mkoeppe commentedon Apr 4, 2018
sagetrac-git commentedon Apr 4, 2018
Branch pushed to git repo; I updated commit sha1. New commits:
19d8539Polyhedron_normaliz: In verbose mode, write out normaliz format filessagetrac-git commentedon Apr 4, 2018
Changed commit from
fcd8101to19d8539sagetrac-git commentedon Apr 4, 2018
Branch pushed to git repo; I updated commit sha1. New commits:
4cfcd14_normaliz_format: Fix last change71 remaining items
tscrim commentedon Sep 16, 2018
Thank you. LGTM.
mkoeppe commentedon Sep 16, 2018
Thanks for reviewing!
vbraun commentedon Sep 16, 2018
sagetrac-git commentedon Sep 16, 2018
Branch pushed to git repo; I updated commit sha1. New commits:
36d5473src/sage/geometry/polyhedron/backend_normaliz.py: Add # optional - pynormalizsagetrac-git commentedon Sep 16, 2018
Changed commit from
f3d11a3to36d5473tscrim commentedon Sep 16, 2018
Whoops, forgot to test on a machine that did not have (py)normaliz installed. Sorry Volker.
vbraun commentedon Sep 19, 2018
Changed branch from public/pynormaliz1.17_normaliz3.6.1 to
36d5473