Skip to content

Upgrade normaliz to 3.5.3 and pynormaliz to 1.12 #22984

Closed

Description

@mkoeppe

Among many new features and improvements, these new versions make computations interruptible with ^C.

Source tarballs:

Upstream bug: Normaliz/Normaliz#176

Follow-up ticket with more cutting-edge PyNormaliz version: #25090.

Upstream: Completely fixed; Fix reported upstream

CC: @w-bruns @sagetrac-tmonteil @videlec @tscrim @jplab @sebasguts

Component: packages: optional

Keywords: IMA-PolyGeom

Author: Matthias Koeppe

Branch/Commit: 7057ef4

Reviewer: Travis Scrimshaw, Thierry Monteil, Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/22984

Activity

  1. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    Author
  2. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    ContributorAuthor
  3. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    Author
  4. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    ContributorAuthor
    comment:3

    Tested on Mac OS X. Works well except for interrupting (may require newer pynormaliz...) and the doctest failures reported in #23586 (fixing broken pynormaliz doctests).


    New commits:

    be0b9d2Upgrade normaliz, pynormaliz
    a6ccc42normaliz: Back out 22684_cone_reduce_memory_usage.patch
  5. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    ContributorAuthor

    Commit: a6ccc42

  6. mkoeppe commented on Aug 26, 2017

    @mkoeppe
    Author
  7. mkoeppe commented on Aug 27, 2017

    @mkoeppe
    ContributorAuthor

    Author: Matthias Koeppe

  8. sagetrac-git commented on Aug 29, 2017

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    5e7a45bUpdate PyNormaliz to 1.8
  9. sagetrac-git commented on Aug 29, 2017

    sagetrac-gitmannequin
    Mannequin

    Changed commit from a6ccc42 to 5e7a45b

  10. mkoeppe commented on Aug 29, 2017

    @mkoeppe
    Author
  11. mkoeppe commented on Mar 3, 2018

    @mkoeppe
    Author
  12. sagetrac-git commented on Mar 3, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    f6011b4Upgrade normaliz to 3.5.1 and pynormaliz to 1.10
    5536407normaliz: Add flint dependency
    71d2194normaliz: Back out 22684_cone_reduce_memory_usage.patch
    f2137ccPolyhedron_normaliz: Adjust doctest to 'uniqueness in output' of normaliz 3.5.1
  13. sagetrac-git commented on Mar 3, 2018

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 5e7a45b to f2137cc

  14. mkoeppe commented on Mar 3, 2018

    @mkoeppe
    Author
  15. tscrim commented on Mar 3, 2018

    @tscrim
    Collaborator
    comment:12

    I am now getting this crash (looks like an upstream problem):

    sage: ieqs = [[0, 2, 0, -1, 0, 0, 0, 0, 0], [0, 0, 2, 0, -1, 0, 0, 0, 0],
    ....:         [1, -1, 0, 2, -1, 0, 0, 0, 0], [0, 0, -1, -1, 2, -1, 0, 0, 0],
    ....:         [0, 0, 0, 0, -1, 2, -1, 0, 0], [0, 0, 0, 0, 0, -1, 2, -1, 0],
    ....:         [0, 0, 0, 0, 0, 0, -1, 2, -1], [2, 0, 0, 0, 0, 0, 0, -1, 2],
    ....:         [0, -1, 0, 0, 0, 0, 0, 0, 0], [0, 0, -1, 0, 0, 0, 0, 0, 0],
    ....:         [0, 0, 0, -1, 0, 0, 0, 0, 0], [0, 0, 0, 0, -1, 0, 0, 0, 0],
    ....:         [0, 0, 0, 0, 0, -1, 0, 0, 0], [0, 0, 0, 0, 0, 0, -1, 0, 0],
    ....:         [0, 0, 0, 0, 0, 0, 0, -1, 0], [0, 0, 0, 0, 0, 0, 0, 0, -1],
    ....:         [-1, -1, -1, -1, -1, -1, -1, -1, -1], [3, 1, 0, 0, 0, 0, 0, 0, 0],
    ....:         [4, 0, 1, 0, 0, 0, 0, 0, 0], [6, 0, 0, 1, 0, 0, 0, 0, 0],
    ....:         [8, 0, 0, 0, 1, 0, 0, 0, 0], [6, 0, 0, 0, 0, 1, 0, 0, 0],
    ....:         [4, 0, 0, 0, 0, 0, 1, 0, 0], [2, 0, 0, 0, 0, 0, 0, 1, 0],
    ....:         [0, 0, 0, 0, 0, 0, 0, 0, 1]]
    sage: P = Polyhedron(ieqs=ieqs, backend='normaliz')
    sage: P.integral_points()
    python2: ./libnormaliz/matrix.cpp:2901: libnormaliz::Matrix<Integer> libnormaliz::Matrix<Integer>::LLL_red(libnormaliz::Matrix<Integer>&, libnormaliz::Matrix<Integer>&) const [with Integer = double]: Assertion `(int) rank()==n' failed.
    ------------------------------------------------------------------------
    /home/travis/sage-build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x574b)[0x7fa5afdf274b]
    /home/travis/sage-build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x57b5)[0x7fa5afdf27b5]
    /home/travis/sage-build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x849a)[0x7fa5afdf549a]
    /lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7fa5bcd37390]
    /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38)[0x7fa5bc991428]
    /lib/x86_64-linux-gnu/libc.so.6(abort+0x16a)[0x7fa5bc99302a]
    /lib/x86_64-linux-gnu/libc.so.6(+0x2dbd7)[0x7fa5bc989bd7]
    /lib/x86_64-linux-gnu/libc.so.6(+0x2dc82)[0x7fa5bc989c82]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZNK11libnormaliz6MatrixIdE7LLL_redERS1_S2_+0x5b9)[0x7fa47314f4a9]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZNK11libnormaliz6MatrixIdE17LLL_red_transposeERS1_S2_+0x83)[0x7fa47314fdc3]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz15LLL_coordinatesIxdEENS_25Sublattice_RepresentationIT_EERKNS_6MatrixIT0_EE+0x56)[0x7fa4730cfde6]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz31LLL_coordinates_without_1st_colIxxEEvRNS_25Sublattice_RepresentationIT_EENS_6MatrixIT0_EES7_b+0x291)[0x7fa4730d0881]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz14ProjectAndLiftIxxE7computeEbb+0x194)[0x7fa473104e54]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz4ConeI10__gmp_exprIA1_12__mpz_structS3_EE16project_and_liftERNS_14ConePropertiesERNS_6MatrixIS4_EERKS9_SA_b+0x839)[0x7fa473179b69]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz4ConeI10__gmp_exprIA1_12__mpz_structS3_EE31try_approximation_or_projectionERNS_14ConePropertiesE+0xf00)[0x7fa4731f5370]
    /home/travis/sage-build/local/lib/libnormaliz.so.3(_ZN11libnormaliz4ConeI10__gmp_exprIA1_12__mpz_structS3_EE7computeENS_14ConePropertiesE+0x1e1)[0x7fa4731e8671]
    /home/travis/sage-build/local/lib/python2.7/site-packages/PyNormaliz_cpp.so(_Z14_NmzResultImplI10__gmp_exprIA1_12__mpz_structS2_EEP7_objectPN11libnormaliz4ConeIT_EES5_+0x75)[0x7fa4734f6cc5]
    /home/travis/sage-build/local/lib/python2.7/site-packages/PyNormaliz_cpp.so(_Z10_NmzResultP7_objectS0_+0x150)[0x7fa4734ed890]
    

    Originally found by

    sage: RC = RiggedConfigurations(['E',8,1], [[3,2]])
    sage: len(RC.module_generators)
    python2: ./libnormaliz/matrix.cpp:2901: libnormaliz::Matrix<Integer> libnormaliz::Matrix<Integer>::LLL_red(libnormaliz::Matrix<Integer>&, libnormaliz::Matrix<Integer>&) const [with Integer = double]: Assertion `(int) rank()==n' failed.
    

    (Mathematical note, through trying to find a smaller example, I am noticing that E8(1) is special in that it is the only place where I see non-full-dimensional non-empty polytopes in my computations. Well, I also see a 0-dimensional polytope for type D4(3), but that doesn't cause a crash as it is likely special-cased.)


    Also can you update the comment before --enable-flint to also say you enable flint as it is part of the standard packages of Sage?

  16. 71 remaining items

  17. tscrim commented on Apr 2, 2018

    @tscrim
    Collaborator
    comment:57

    Replying to @jplab:

    @tscrim: Do you still want to add a comment about the verbose of Polyhedron?

    It can be on a separate ticket, but the docstring for verbose should also say it is supported for the normaliz backend as well.

  18. jplab commented on Apr 2, 2018

    @jplab
    Contributor
    comment:58

    Replying to @tscrim:

    Replying to @jplab:

    @tscrim: Do you still want to add a comment about the verbose of Polyhedron?

    It can be on a separate ticket, but the docstring for verbose should also say it is supported for the normaliz backend as well.

    I went ahead and made the change already... I realized it was not a big deal.

  19. tscrim commented on Apr 2, 2018

    @tscrim
    Collaborator
    comment:59

    Ah, thanks. I didn't look at the diffs.

  20. jplab commented on Apr 3, 2018

    @jplab
    Contributor
  21. jplab commented on Apr 3, 2018

    @jplab
    Contributor

    Changed commit from 117e428 to 7057ef4

  22. jplab commented on Apr 3, 2018

    @jplab
    Contributor
    comment:60

    Merged the forgotten commit.


    New commits:

    7f47ec9Adapted the polyhedron docstring
    7057ef4Merge branch to get docstring adaptation
  23. mkoeppe commented on Apr 4, 2018

    @mkoeppe
    ContributorAuthor

    Changed keywords from none to IMA-PolyGeom

  24. mkoeppe commented on Apr 4, 2018

    @mkoeppe
    Author
  25. modified the milestones: sage-8.2, sage-8.3 on Apr 13, 2018
  26. vbraun commented on May 8, 2018

    @vbraun
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions