Skip to content

convert guava interface to libgap #28820

Closed

Description

@dimpase

turns out to be straightforward, and much cleaner

CC: @wdjoyner

Component: coding theory

Author: Dima Pasechnik

Branch: f4b8c13

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28820

Activity

  1. added this to the sage-9.0 milestone on Nov 29, 2019
  2. dimpase commented on Nov 29, 2019

    @dimpase
    MemberAuthor
    comment:1

    branch coming

  3. dimpase commented on Nov 29, 2019

    @dimpase
    Author
  4. dimpase commented on Nov 29, 2019

    @dimpase
    MemberAuthor

    New commits:

    f4b8c13convert guava interface to libgap
  5. dimpase commented on Nov 29, 2019

    @dimpase
    MemberAuthor

    Commit: f4b8c13

  6. dimpase commented on Nov 29, 2019

    @dimpase
    MemberAuthor
  7. fchapoton commented on Nov 30, 2019

    @fchapoton
    Contributor

    Reviewer: Frédéric Chapoton

  8. fchapoton commented on Nov 30, 2019

    @fchapoton
    Contributor
    comment:3

    ok, looks good and works for me

  9. vbraun commented on Dec 1, 2019

    @vbraun
    Member

    Changed branch from u/dimpase/coding/guavalibgap to f4b8c13

  10. dimpase commented on Dec 1, 2019

    @dimpase
    MemberAuthor

    Changed commit from f4b8c13 to none

  11. dimpase commented on Dec 1, 2019

    @dimpase
    MemberAuthor
    comment:5

    Thanks. Please also look at #28818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions