feat: enable VFIO also on amd64 - #854
Merged
Merged
Conversation
Contributor
Author
|
I had a thought - would it more preferable modularised instead of builtin?
As @smira has pointed out on Slack, VFIO actually does get picked up for certain virtual functions (see https://cateee.net/lkddb/web-lkddb/VFIO.html). On the other hand, it is often used for other devices where it needs to be manually configured to pick them up. |
Member
263a264,270
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/pci
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/pci/vfio-pci-core.ko
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/pci/vfio-pci.ko
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/vfio_iommu_type1.ko
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/vfio.ko
> ./lib/modules/6.1.67-talos/kernel/drivers/vfio/vfio_virqfd.ko
301c308
< 109 directories, 190 files
---
> 111 directories, 195 filesSize: |
On arm64 platform, the relevant VFIO configs are enabled already. This patch synchronizes both. Signed-off-by: Radosław Piliszek <radoslaw.piliszek@gmail.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
amd64-add-vfio
branch
from
December 18, 2023 11:20
2b7212c to
6af1691
Compare
Contributor
Author
|
I approve from my side. This is in vein with the Talos approach as I see it. Thanks. |
smira
approved these changes
Dec 18, 2023
smira
left a comment
smira
left a comment
Member
There was a problem hiding this comment.
reworked to use modules on both architectures
Member
|
/m |
Member
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 18, 2023
See: * siderolabs/pkgs#854 * siderolabs/pkgs#855 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 19, 2023
See: * siderolabs/pkgs#854 * siderolabs/pkgs#855 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On arm64 platform, the relevant VFIO configs are enabled already. This patch synchronizes both.