feat: enable modules for mlx infiniband - #855
Merged
Merged
Conversation
mlx4 and mlx5 core and ethernet modules are enabled. Infiniband and IPoIB are also enabled. And this patch enables the remaining bits to get most Infiniband hardware working out of the box. Requires inclusion of the new modules in the list for initramfs to support cases like booting from or otherwise early use of the Infiniband network. Signed-off-by: Radosław Piliszek <radoslaw.piliszek@gmail.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
changed the title
smira
approved these changes
Dec 15, 2023
Member
|
module diff: 75a76,80
> ./lib/modules/6.1.67-talos/kernel/drivers/infiniband/hw
> ./lib/modules/6.1.67-talos/kernel/drivers/infiniband/hw/mlx4
> ./lib/modules/6.1.67-talos/kernel/drivers/infiniband/hw/mlx4/mlx4_ib.ko
> ./lib/modules/6.1.67-talos/kernel/drivers/infiniband/hw/mlx5
> ./lib/modules/6.1.67-talos/kernel/drivers/infiniband/hw/mlx5/mlx5_ib.ko
301c306
< 109 directories, 190 files
---
> 112 directories, 192 filesnew modules size: |
frezbo
approved these changes
Dec 15, 2023
Member
|
looks like these modules need to be loaded explicitly. I wonder if they should go to a system extension? |
Contributor
Author
|
Nope, they get loaded automatically by core when it senses a port configured for Infiniband. |
Contributor
Author
|
(continuing on the previous comment) Analogously, when core senses an Ethernet port, it loads the _en module (and this is now working out of the box). |
Member
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 18, 2023
See: * siderolabs/pkgs#854 * siderolabs/pkgs#855 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 19, 2023
See: * siderolabs/pkgs#854 * siderolabs/pkgs#855 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx4 and mlx5 core and ethernet modules are enabled. Infiniband and IPoIB are also enabled.
And this patch enables the remaining bits to get most Infiniband hardware working out of the box.
Requires inclusion of the new modules in the list for initramfs to support cases like booting from or otherwise early use of the Infiniband network.