Skip to content

build(deps): update petgraph to 0.8 - #1327

Merged
caspermeijn merged 4 commits into
tokio-rs:masterfrom
rerun-io:chore/update-petgraph-0.8
Sep 18, 2025
Merged

caspermeijn merged 4 commits into
tokio-rs:masterfrom
rerun-io:chore/update-petgraph-0.8

Conversation

@timsaucer

Copy link
Copy Markdown
Contributor

Update dependency

@timsaucer

timsaucer commented Sep 11, 2025 •

Copy link
Copy Markdown
Contributor Author

Since the plan is to keep prost in line with tokio and tokio is not interested in updating MSRV right now, the no-default-features for petgraph in 0.8 will not pass CI. That requires at least rust 1.81 which has core::error::Error stable for use with #![no_std]. We cannot pass this as a features = ["std"] to the petgraph dependency because versions 0.6 and 0.7 do not have it.

Instead, just changing the dep here to stick it to 0.8 instead of allowing a range.

@timsaucer
timsaucer marked this pull request as ready for review September 11, 2025 14:51
@caspermeijn

Copy link
Copy Markdown
Member

Since the plan is to keep prost in line with tokio and tokio is not interested in updating MSRV right now, the no-default-features for petgraph in 0.8 will not pass CI. That requires at least rust 1.81 which has core::error::Error stable for use with #![no_std]. We cannot pass this as a features = ["std"] to the petgraph dependency because versions 0.6 and 0.7 do not have it.

So, prost follows the same MSRV policy, but not nessesaribly the same MSRV version. So a version bump is possible if that is needed for the project. However, an MSRV bump for a build-dependency update doesn't feel right.

Instead, just changing the dep here to stick it to 0.8 instead of allowing a range.

petgraph 0.8 is now 6 months old, so dropping the older versions is fine with me.

@caspermeijn caspermeijn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to my attention.

@caspermeijn caspermeijn changed the title update petgraph to 0.8 build(deps): update petgraph to 0.8 Sep 18, 2025
@caspermeijn
caspermeijn added this pull request to the merge queue Sep 18, 2025
Merged via the queue into tokio-rs:master with commit 3235b0c Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants