You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ComboBox logs "property update request for disabled element" with WARN level when its container is disabled #2490
The following code causes "property update request for disabled element" messages to be logged with WARN level. According to vaadin/flow#8848, vaadin/flow#9473 the log level should be lowered since this is an expected occurrence.
Div div = new Div();
div.setEnabled(false);
div.add(new ComboBox<>());
add(div);
2021-11-18 16:51:10.911 WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler : Property update request for disabled element is received from the client side. The property is 'filter'. Request is ignored.
2021-11-18 16:51:10.911 WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler : Property update request for disabled element is received from the client side. The property is 'invalid'. Request is ignored.
2021-11-18 16:51:10.911 WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler : Property update request for disabled element is received from the client side. The property is 'opened'. Request is ignored.
WARN : Property update request for disabled element is received from the client side. The property is 'invalid'. Request is ignored.
WARN : Property update request for disabled element is received from the client side. The property is 'value'. Request is ignored.
WARN : Property update request for disabled element is received from the client side. The property is 'opened'. Request is ignored.
WARN : Property update request for disabled element is received from the client side. The property is 'filter'. Request is ignored.
We have a ComboBox that is within a larger container that is enabled/disabled by a Checkbox - a very typical use case.
We can't have useless warnings spewing like this all day and filling up our logs and triggering automated service alerts.
This also happens for AccordionPanel, DatePicker, TimePicker, DateTimePicker (for 4 warnings alone for this one) and, at this point I can only assume, others. Do we need separate tickets for these? Tested with Vaadin 23.
Poking around the issue it would seem like the problem is with any property set with @Synchronize that doesn't have the default value set. So for instance with ComboBox if you would have the default values for the 4 properties
Activity
caalador commentedon Nov 19, 2021
As per vaadin/flow#9473 (comment) the issue should be addressed in the component to not make the requests when it is disabled.
archiecobbs commentedon Feb 8, 2022
Still happening (Vaadin 22).
We have a ComboBox that is within a larger container that is enabled/disabled by a Checkbox - a very typical use case.
We can't have useless warnings spewing like this all day and filling up our logs and triggering automated service alerts.
Frettman commentedon Mar 13, 2022
This also happens for
AccordionPanel,DatePicker,TimePicker,DateTimePicker(for 4 warnings alone for this one) and, at this point I can only assume, others. Do we need separate tickets for these? Tested with Vaadin 23.caalador commentedon Apr 12, 2022
Poking around the issue it would seem like the problem is with any property set with
@Synchronizethat doesn't have the default value set. So for instance with ComboBox if you would have the default values for the 4 propertiesThen no warnings for these are logged when the component is disabled.
fix: do not warn for unset disabled property change
fix: do not warn for unset disabled property change (#13509)
fix: do not warn for unset disabled property change (#13509)
fix: do not warn for unset disabled property change (#13509)
fix: do not warn for unset disabled property change (#13509)
fix: do not warn for unset disabled property change (#13509) (#13514)
fix: do not warn for unset disabled property change (#13509) (#13513)
fix: do not warn for unset disabled property change (#13509) (#13515)
fix: do not warn for unset disabled property change (#13509) (#13515)
fix: do not warn for unset disabled property change (#13509) (#13515)
fix: do not warn for unset disabled property change (#13509) (#13515) (…
vaadin-bot commentedon Apr 26, 2022
This ticket/PR has been released with Vaadin 23.0.7.
vaadin-bot commentedon Jun 3, 2022
This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.