Skip to content

ComboBox logs "property update request for disabled element" with WARN level when its container is disabled #2490

Closed
vaadin/flow
#13509

Description

@javier-godoy

The following code causes "property update request for disabled element" messages to be logged with WARN level. According to vaadin/flow#8848, vaadin/flow#9473 the log level should be lowered since this is an expected occurrence.

    Div div = new Div();
    div.setEnabled(false);
    div.add(new ComboBox<>());
    add(div);
2021-11-18 16:51:10.911  WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler          : Property update request for disabled element is received from the client side. The property is 'filter'. Request is ignored.
2021-11-18 16:51:10.911  WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler          : Property update request for disabled element is received from the client side. The property is 'invalid'. Request is ignored.
2021-11-18 16:51:10.911  WARN 32464 --- [nio-8014-exec-6] c.v.f.s.c.rpc.MapSyncRpcHandler          : Property update request for disabled element is received from the client side. The property is 'opened'. Request is ignored.

Vaadin 14.7.0

Activity

  1. caalador commented on Nov 19, 2021

    @caalador
    Contributor

    As per vaadin/flow#9473 (comment) the issue should be addressed in the component to not make the requests when it is disabled.

  2. transferred this issue fromvaadin/flowon Jan 11, 2022
  3. archiecobbs commented on Feb 8, 2022

    @archiecobbs

    Still happening (Vaadin 22).

    WARN : Property update request for disabled element is received from the client side. The property is 'invalid'. Request is ignored.
    WARN : Property update request for disabled element is received from the client side. The property is 'value'. Request is ignored.
    WARN : Property update request for disabled element is received from the client side. The property is 'opened'. Request is ignored.
    WARN : Property update request for disabled element is received from the client side. The property is 'filter'. Request is ignored.
    

    We have a ComboBox that is within a larger container that is enabled/disabled by a Checkbox - a very typical use case.

    We can't have useless warnings spewing like this all day and filling up our logs and triggering automated service alerts.

  4. Frettman commented on Mar 13, 2022

    @Frettman

    This also happens for AccordionPanel, DatePicker, TimePicker, DateTimePicker (for 4 warnings alone for this one) and, at this point I can only assume, others. Do we need separate tickets for these? Tested with Vaadin 23.

  5. self-assigned this
    on Apr 5, 2022
  6. self-assigned this
    on Apr 12, 2022
  7. caalador commented on Apr 12, 2022

    @caalador
    Contributor

    Poking around the issue it would seem like the problem is with any property set with @Synchronize that doesn't have the default value set. So for instance with ComboBox if you would have the default values for the 4 properties

            Element cbElement = comboBox.getElement();
            cbElement.setProperty("invalid", false);
            cbElement.setProperty("value", "");
            cbElement.setProperty("opened", false);
            cbElement.setProperty("filter", "");
    

    Then no warnings for these are logged when the component is disabled.

  8. added a commit that references this issue on Apr 12, 2022
    ccbff2d
  9. added a commit that references this issue on Apr 12, 2022
    bea1106
  10. added 2 commits that reference this issue on Apr 12, 2022
    0acab38
    34e7ea7
  11. added 3 commits that reference this issue on Apr 12, 2022
    54225c9
    55c83ef
    e9bce25
  12. added a commit that references this issue on Apr 13, 2022
    4e454fd
  13. added a commit that references this issue on Apr 13, 2022
    112b825
  14. added a commit that references this issue on Apr 13, 2022
    7106edc
  15. added a commit that references this issue on Apr 13, 2022
    e616032
  16. vaadin-bot commented on Apr 26, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.0.7.

  17. vaadin-bot commented on Jun 3, 2022

    @vaadin-bot
    Collaborator

    This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions