Skip to content

Resetting DateTimePicker's overlayClassName does not work #6274

Closed
vaadin/web-components
#7386

Description

@JoMWal

Description

I added a DateTimePicker to a view and set DateTimePicker component's overlayClassName.
Trying to reset overlayClassName property breaks the component:

image

  • Seems to me as web component's input component is not generated. There are errors in browser console:
    image
  • same with DatePicker

Expected outcome

After resetting reset overlayClassName property DateTimePicker is displayed as before setting overlayClassName at all.

Minimal reproducible example

@Route
public class MainView extends VerticalLayout {

    public MainView() {

        DateTimePicker dateTimePicker = new DateTimePicker("Default");
        
        DateTimePicker dateTimePicker2 = new DateTimePicker("Reset with setOverlayClassName(null)");
        dateTimePicker2.setOverlayClassName("example");
        dateTimePicker2.setOverlayClassName(null);
        
        DateTimePicker dateTimePicker3 = new DateTimePicker("Reset with setOverlayClassName(\"\")");
        dateTimePicker3.setOverlayClassName("example");
        dateTimePicker3.setOverlayClassName("");
        
        DateTimePicker dateTimePicker4 = new DateTimePicker("Reset with getElement().setProperty(\"overlayClass\", null)");
        dateTimePicker4.setOverlayClassName("example");
        dateTimePicker4.getElement().setProperty("overlayClass", null);

        add(dateTimePicker);
        add(dateTimePicker2);
        add(dateTimePicker3);
        add(dateTimePicker4);
    }
}

Steps to reproduce

  1. Create new Vaadin app (Used maven archetype)
  2. Edit "MainView" as in "Minimal reproducible example"
  3. Start with jetty

Environment

Vaadin version(s): 24.3.10
OS: Win10

Browsers

No response

Activity

  1. web-padawan commented on May 6, 2024

    @web-padawan
    Member

    Thanks for the issue. Confirmed it using the web component. I'll add a check to ensure empty overlayClass doesn't throw.

  2. self-assigned this
    on May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions