Repository navigation
fix: do not throw when overlayClass is set to empty string - #7386
Merged
Merged
Conversation
web-padawan
commented
May 6, 2024
|
|
||
| // Add new classes based on the overlayClass | ||
| const classesToAdd = typeof overlayClass === 'string' ? overlayClass.split(' ') : []; | ||
| const classesToAdd = typeof overlayClass === 'string' ? overlayClass.split(' ').filter(Boolean) : []; |
Member
Author
There was a problem hiding this comment.
The reason of the problem is that ''.split(' ') produces an array [''] so we need to filter out empty string.
web-padawan
force-pushed
the
fix/overlay-class-empty-string
branch
from
May 6, 2024 13:42
e67addd to
355bf34
Compare
|
vursen
approved these changes
May 7, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 7, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 7, 2024
web-padawan
added a commit
that referenced
this pull request
May 7, 2024
web-padawan
added a commit
that referenced
this pull request
May 7, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Fixes vaadin/flow-components#6274
Type of change