Skip to content

[map] Viewport change event - #2569

Merged
sissbruecker merged 10 commits into
feat/mapfrom
feat/map-move-end-event
Jan 26, 2022
Merged

sissbruecker merged 10 commits into
feat/mapfrom
feat/map-move-end-event

Conversation

@hdamr

@hdamr hdamr commented Jan 26, 2022 •

Copy link
Copy Markdown
Contributor

Adds support for viewport change event (center, zoom, rotation, extent).
Adds IT for updating view states.
Fixes: #2501

@hdamr
hdamr marked this pull request as ready for review January 26, 2022 08:24
@hdamr
hdamr requested a review from sissbruecker January 26, 2022 08:25
@sissbruecker
sissbruecker force-pushed the feat/map-move-end-event branch from 4064f02 to 60c966e Compare January 26, 2022 16:04
@sissbruecker
sissbruecker merged commit c51b91b into feat/map Jan 26, 2022
@sissbruecker
sissbruecker deleted the feat/map-move-end-event branch January 26, 2022 16:18
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

manolo pushed a commit that referenced this pull request Jan 28, 2022
* add support for map move end event.

* add center, zoom to move-end event.

* add view extent.

* add IT for view state change.

* run formatter.

* apply review comments.

* apply review comments.

* move register event listener to constructor.

* Fix grammar.

* add minor improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
manolo pushed a commit that referenced this pull request Jan 28, 2022
* add support for map move end event.

* add center, zoom to move-end event.

* add view extent.

* add IT for view state change.

* run formatter.

* apply review comments.

* apply review comments.

* move register event listener to constructor.

* Fix grammar.

* add minor improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
manolo pushed a commit that referenced this pull request Jan 31, 2022
* add support for map move end event.

* add center, zoom to move-end event.

* add view extent.

* add IT for view state change.

* run formatter.

* apply review comments.

* apply review comments.

* move register event listener to constructor.

* Fix grammar.

* add minor improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Jan 31, 2022
* chore: add basic map component module

* chore: make map configuration observable

* chore: add pattern for options

* chore: add default map

* chore: add basic feature support

* chore: rename base layer to background layer

* chore: add license header

* chore: adapt sync calls

* chore: apply formatting

* feat: finalize background layer (#2531)

* feat: finalize background layer

* fix typo

* fix opaque option default value

* add unit test for map

* chore: add map connector and move client-side sync logic (#2533)

* feat: map component View methods (#2541)

* Null checking for center property.

* Add IT for setCenter, setZoom and setRotation

* add IT for view methods, add basic unit test for view, adding some doc for view class.

* Improve comments, add support for setting projection in the constructor.

* small code improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>

* feat: allow silent configuration updates (#2547)

* feat: allow silent configuration updates

* run formatter

* fix: notify flag thread local initial value (#2556)

* fix: notify flag thread local initial value

* run formatter

* feat: implement feature flag (#2554)

* [map] Viewport change event (#2569)

* add support for map move end event.

* add center, zoom to move-end event.

* add view extent.

* add IT for view state change.

* run formatter.

* apply review comments.

* apply review comments.

* move register event listener to constructor.

* Fix grammar.

* add minor improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>

* fix type name checks in ITs

* enable NPM package annotation

* align jetty configuration with other modules

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>

* fix flaky test

* chore: add map component to comercial list

* chore: apply format rules

* chore: remove duplicate module

* fix: clear thead local after use

* ignore random usage in demo page

* ignore random usage in demo page

Co-authored-by: Hadi Amiri <84700249+hdamr@users.noreply.github.com>
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
Co-authored-by: Manolo Carrasco <manolo@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants