Skip to content

feat: add map component behind feature flag - #2576

Merged
sissbruecker merged 26 commits into
masterfrom
feat/map
Jan 31, 2022
Merged

sissbruecker merged 26 commits into
masterfrom
feat/map

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Adds the map component from the feature branch to master.

Type of change

  • Feature

@manolo
manolo force-pushed the feat/map branch 2 times, most recently from feb251a to e9934a8 Compare January 28, 2022 10:28
sissbruecker and others added 21 commits January 31, 2022 05:58
* feat: finalize background layer

* fix typo

* fix opaque option default value

* add unit test for map
* Null checking for center property.

* Add IT for setCenter, setZoom and setRotation

* add IT for view methods, add basic unit test for view, adding some doc for view class.

* Improve comments, add support for setting projection in the constructor.

* small code improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
* feat: allow silent configuration updates

* run formatter
* fix: notify flag thread local initial value

* run formatter
* add support for map move end event.

* add center, zoom to move-end event.

* add view extent.

* add IT for view state change.

* run formatter.

* apply review comments.

* apply review comments.

* move register event listener to constructor.

* Fix grammar.

* add minor improvements

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@manolo

manolo commented Jan 31, 2022

Copy link
Copy Markdown
Member

Validation passes now, please fix sonar and promote from draft to PR

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 101 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker marked this pull request as ready for review January 31, 2022 10:37
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants