Repository navigation
feat: add map component behind feature flag - #2576
Merged
Merged
Conversation
tomivirkki
reviewed
Jan 27, 2022
manolo
force-pushed
the
feat/map
branch
2 times, most recently
from
January 28, 2022 10:28
feb251a to
e9934a8
Compare
* feat: finalize background layer * fix typo * fix opaque option default value * add unit test for map
* Null checking for center property. * Add IT for setCenter, setZoom and setRotation * add IT for view methods, add basic unit test for view, adding some doc for view class. * Improve comments, add support for setting projection in the constructor. * small code improvements Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
* feat: allow silent configuration updates * run formatter
* fix: notify flag thread local initial value * run formatter
* add support for map move end event. * add center, zoom to move-end event. * add view extent. * add IT for view state change. * run formatter. * apply review comments. * apply review comments. * move register event listener to constructor. * Fix grammar. * add minor improvements Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
Member
|
Validation passes now, please fix sonar and promote from draft to PR |
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
marked this pull request as ready for review
January 31, 2022 10:37
manolo
approved these changes
Jan 31, 2022
tomivirkki
reviewed
Jan 31, 2022
Collaborator
|
This ticket/PR has been released with platform 23.0.0.beta1 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Adds the map component from the feature branch to master.
Type of change