Skip to content

fix: update selected property on selected change - #3851

Merged
web-padawan merged 2 commits into
masterfrom
fix/sync-selected-property
Oct 12, 2022
Merged

web-padawan merged 2 commits into
masterfrom
fix/sync-selected-property

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Follow-up for #3846

Since the selected index can change due to various reasons, it's safer to synchronize the property value inside the internal selected change listener.

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 1b9be4a into master Oct 12, 2022
@web-padawan
web-padawan deleted the fix/sync-selected-property branch October 12, 2022 07:13
vursen added a commit that referenced this pull request Feb 16, 2026
sissbruecker pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants