Repository navigation
Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" - #8700
Merged
Merged
Conversation
|
sissbruecker
approved these changes
Feb 16, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…" (#8700) * Revert "fix: update selected property on selected change (#3851)" This reverts commit 1b9be4a. * Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" This reverts commit a2ad98c. * test: add integration test for TabSheet initial selection Verifies that setting the selected index before attach correctly selects the tab and displays the corresponding content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * format code --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…" (#8700) * Revert "fix: update selected property on selected change (#3851)" This reverts commit 1b9be4a. * Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" This reverts commit a2ad98c. * test: add integration test for TabSheet initial selection Verifies that setting the selected index before attach correctly selects the tab and displays the corresponding content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * format code --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…" (#8700) * Revert "fix: update selected property on selected change (#3851)" This reverts commit 1b9be4a. * Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" This reverts commit a2ad98c. * test: add integration test for TabSheet initial selection Verifies that setting the selected index before attach correctly selects the tab and displays the corresponding content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * format code --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vursen
added a commit
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Programmatically updating the
selectedproperty insideaddSelectedChangeListenercan cause an infinite loop when selecting a tab while another tab's selection is still being processed: the tabs begin endlessly switching back and forth.The
selectedproperty logic was added in #3846 to fix initial tab selection, but the new IT test in this PR confirms that everything works as expected without that logic, so this PR removes it.Fixes #8699
Type of change