Skip to content

Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" - #8700

Merged
sissbruecker merged 5 commits into
mainfrom
fix-tab-regression
Feb 16, 2026
Merged

sissbruecker merged 5 commits into
mainfrom
fix-tab-regression

Conversation

@vursen

@vursen vursen commented Feb 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Programmatically updating the selected property inside addSelectedChangeListener can cause an infinite loop when selecting a tab while another tab's selection is still being processed: the tabs begin endlessly switching back and forth.

The selected property logic was added in #3846 to fix initial tab selection, but the new IT test in this PR confirms that everything works as expected without that logic, so this PR removes it.

Fixes #8699

Type of change

  • Bugfix / Revert

vursen and others added 4 commits February 16, 2026 15:58
Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vursen
vursen marked this pull request as ready for review February 16, 2026 12:30
@vursen
vursen requested a review from tomivirkki February 16, 2026 12:31
@sonarqubecloud

Copy link
Copy Markdown

@sissbruecker
sissbruecker merged commit f88733f into main Feb 16, 2026
6 checks passed
@sissbruecker
sissbruecker deleted the fix-tab-regression branch February 16, 2026 13:51
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vaadin-bot pushed a commit that referenced this pull request Feb 16, 2026
…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vursen added a commit that referenced this pull request Feb 16, 2026
…" (#8700) (#8702)

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite loop when navigating away from a tab that is being loaded

3 participants