Skip to content

Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)" (#8700) (CP: 25.0) - #8702

Merged
vursen merged 1 commit into
25.0from
cherry-pick-8700-to-25.0-1771250217548
Feb 16, 2026
Merged

vursen merged 1 commit into
25.0from
cherry-pick-8700-to-25.0-1771250217548

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #8700 to branch 25.0.


Description

Programmatically updating the selected property inside addSelectedChangeListener can cause an infinite loop when selecting a tab while another tab's selection is still being processed: the tabs begin endlessly switching back and forth.

The selected property logic was added in #3846 to fix initial tab selection, but the new IT test in this PR confirms that everything works as expected without that logic, so this PR removes it.

Fixes #8699

Type of change

  • Bugfix / Revert

…" (#8700)

* Revert "fix: update selected property on selected change (#3851)"

This reverts commit 1b9be4a.

* Revert "fix: set tabsheet selected property on setSelectedIndex (#3846)"

This reverts commit a2ad98c.

* test: add integration test for TabSheet initial selection

Verifies that setting the selected index before attach correctly
selects the tab and displays the corresponding content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* format code

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@vursen
vursen merged commit 926b522 into 25.0 Feb 16, 2026
6 checks passed
@vursen
vursen deleted the cherry-pick-8700-to-25.0-1771250217548 branch February 16, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants