Skip to content

fix: Annotate default error handlers. - #11063

Merged
pleku merged 2 commits into
masterfrom
issues/661_default_handlers
May 27, 2021
Merged

pleku merged 2 commits into
masterfrom
issues/661_default_handlers

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661

Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
caalador added a commit to vaadin/spring that referenced this pull request May 24, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

requires vaadin/flow#11063

fixes #661
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MINOR AbstractRouteRegistry.java#L353: Remove useless curly braces around statement rule
  2. INFO AbstractRouteRegistry.java#L271: Do not forget to remove this deprecated code someday. rule

@pleku
pleku merged commit 43b5efc into master May 27, 2021
@pleku
pleku deleted the issues/661_default_handlers branch May 27, 2021 05:54
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @caalador , this commit cannot be picked to 7.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 43b5efc
error: could not apply 43b5efc... fix: Annotate default error handlers. (#11063)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @caalador , this commit cannot be picked to 2.7 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 43b5efc
error: could not apply 43b5efc... fix: Annotate default error handlers. (#11063)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

caalador added a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
caalador added a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java
pleku pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
pleku pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java
vaadin-bot pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
vaadin-bot pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java
pleku pushed a commit to vaadin/spring that referenced this pull request May 27, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires vaadin/flow#11063

Fixes #661
vaadin-bot pushed a commit to vaadin/spring that referenced this pull request May 27, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires vaadin/flow#11063

Fixes #661
vaadin-bot pushed a commit to vaadin/spring that referenced this pull request May 27, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires vaadin/flow#11063

Fixes #661
pleku pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
pleku pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
pleku pushed a commit to vaadin/spring that referenced this pull request Jun 3, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires vaadin/flow#11063

Fixes #661

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
pleku pushed a commit to vaadin/spring that referenced this pull request Jun 3, 2021
Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires vaadin/flow#11063

Fixes #661

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha3. For prerelease versions, it will be included in its final version.

manolo pushed a commit that referenced this pull request Feb 8, 2022
vaadin/spring#815

Annotate SpringRouteNotFoundError with
DefaultErrorHandler so that users can
make custom error views for NotFoundException

Requires #11063

Fixes: vaadin/spring#661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants