Skip to content

fix: Annotate default error handlers. (#11063) - #11090

Merged
pleku merged 1 commit into
7.0from
cherry/cherrypick-11063-to-7.0
May 27, 2021
Merged

pleku merged 1 commit into
7.0from
cherry/cherrypick-11063-to-7.0

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661

Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MINOR AbstractRouteRegistry.java#L353: Remove useless curly braces around statement rule
  2. INFO AbstractRouteRegistry.java#L271: Do not forget to remove this deprecated code someday. rule

@pleku
pleku merged commit eb0d582 into 7.0 May 27, 2021
@pleku
pleku deleted the cherry/cherrypick-11063-to-7.0 branch May 27, 2021 08:17
vaadin-bot pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java
pleku pushed a commit that referenced this pull request May 27, 2021
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/router/InternalServerError.java
#	flow-server/src/main/java/com/vaadin/flow/router/RouteNotFoundError.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 20.0.0. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants