Skip to content

feat: enable pwa for vite - #12363

Merged
joheriks merged 10 commits into
masterfrom
vite/pwa
Nov 24, 2021
Merged

joheriks merged 10 commits into
masterfrom
vite/pwa

Conversation

@caalador

@caalador caalador commented Nov 15, 2021 •

Copy link
Copy Markdown
Contributor

Enable pwa installation for vite.

Part of #12052

@caalador caalador added pwa vite Tickets related to vite support labels Nov 15, 2021
@caalador
caalador force-pushed the vite/pwa branch 2 times, most recently from f12701a to 828e50c Compare November 15, 2021 12:13
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Nov 19, 2021
Use on setting for file, renames.
Add comments to config
Artur-
Artur- previously approved these changes Nov 19, 2021
@Artur-

Artur- commented Nov 19, 2021

Copy link
Copy Markdown
Member

Some conflicts remain

@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Nov 19, 2021
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Nov 22, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR NodeTasks.java#L1: Class com.vaadin.flow.server.frontend.NodeTasks$Builder defines non-transient non-serializable instance field lookup rule
  2. MAJOR NodeTasks.java#L148: Make "lookup" transient or serializable. rule

@joheriks
joheriks merged commit 3782701 into master Nov 24, 2021
@joheriks
joheriks deleted the vite/pwa branch November 24, 2021 14:23
caalador added a commit that referenced this pull request Dec 3, 2021
Enable pwa installation for vite.
PWA doesn't work in development
mode with this feature.

Part of #12052
joheriks pushed a commit that referenced this pull request Dec 3, 2021
Enable pwa installation for vite.
PWA doesn't work in development
mode with this feature.

Part of #12052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-9.0 pwa vite Tickets related to vite support +0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants