Skip to content

feat: enable pwa for vite (#12363) - #12507

Merged
joheriks merged 1 commit into
9.0from
cherrypick/cherrypick-12363-to-9.0
Dec 3, 2021
Merged

joheriks merged 1 commit into
9.0from
cherrypick/cherrypick-12363-to-9.0

Conversation

@caalador

@caalador caalador commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

Enable pwa installation for vite.
PWA doesn't work in development
mode with this feature.

Part of #12052

Enable pwa installation for vite.
PWA doesn't work in development
mode with this feature.

Part of #12052
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR NodeTasks.java#L1: Class com.vaadin.flow.server.frontend.NodeTasks$Builder defines non-transient non-serializable instance field lookup rule
  2. MAJOR NodeTasks.java#L148: Make "lookup" transient or serializable. rule

@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

Unit Test Results

   713 files     713 suites   16m 27s ⏱️
5 596 tests 5 547 ✔️ 49 💤 0 ❌
5 612 runs  5 563 ✔️ 49 💤 0 ❌

Results for commit 4078b17.

@joheriks
joheriks merged commit ba1db11 into 9.0 Dec 3, 2021
@joheriks
joheriks deleted the cherrypick/cherrypick-12363-to-9.0 branch December 3, 2021 10:24
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants