Skip to content

fix: provide correct devMode flag to theme-generator with Vite (#14230) (CP: 23.1) - #14231

Merged
mcollovati merged 1 commit into
23.1from
cherry-pick-14230-to-23.1-1659009687685
Jul 28, 2022
Merged

mcollovati merged 1 commit into
23.1from
cherry-pick-14230-to-23.1-1659009687685

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

devMode flag was hard-coded to false in theme options, preventing the theme generator
plugin to work correctly when styles.css does not exist

Fixes #14228
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   972 files  ±0     972 suites  ±0   1h 4m 32s ⏱️ + 4m 5s
6 324 tests ±0  6 275 ✔️ ±0  49 💤 ±0  0 ❌ ±0 
6 549 runs   - 1  6 494 ✔️  - 1  55 💤 ±0  0 ❌ ±0 

Results for commit 03bdfba. ± Comparison against base commit 8a17462.

@mcollovati
mcollovati merged commit be28afc into 23.1 Jul 28, 2022
@mcollovati
mcollovati deleted the cherry-pick-14230-to-23.1-1659009687685 branch July 28, 2022 12:38
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants